Skip to content

Commit

Permalink
Change filenames to match project convention (#3771)
Browse files Browse the repository at this point in the history
  • Loading branch information
justinfagnani committed Mar 30, 2023
1 parent 7c1191d commit 89da3d8
Show file tree
Hide file tree
Showing 14 changed files with 54 additions and 47 deletions.
5 changes: 5 additions & 0 deletions .changeset/beige-baboons-promise.md
@@ -0,0 +1,5 @@
---
'@lit-labs/observers': major
---

Change filenames to match project convention: replace `_` with `-`.
9 changes: 5 additions & 4 deletions .eslintignore
Expand Up @@ -239,10 +239,11 @@ packages/labs/observers/development/
packages/labs/observers/test/
packages/labs/observers/node_modules/
packages/labs/observers/index.*
packages/labs/observers/mutation_controller.*
packages/labs/observers/performance_controller.*
packages/labs/observers/resize_controller.*
packages/labs/observers/intersection_controller.*
packages/labs/observers/mutation-controller.*
packages/labs/observers/performance-controller.*
packages/labs/observers/resize-controller.*
packages/labs/observers/intersection-controller.*

packages/labs/react/development/
packages/labs/react/test/
packages/labs/react/node_modules/
Expand Down
9 changes: 5 additions & 4 deletions .prettierignore
Expand Up @@ -226,10 +226,11 @@ packages/labs/observers/development/
packages/labs/observers/test/
packages/labs/observers/node_modules/
packages/labs/observers/index.*
packages/labs/observers/mutation_controller.*
packages/labs/observers/performance_controller.*
packages/labs/observers/resize_controller.*
packages/labs/observers/intersection_controller.*
packages/labs/observers/mutation-controller.*
packages/labs/observers/performance-controller.*
packages/labs/observers/resize-controller.*
packages/labs/observers/intersection-controller.*

packages/labs/react/development/
packages/labs/react/test/
packages/labs/react/node_modules/
Expand Down
8 changes: 4 additions & 4 deletions packages/labs/observers/.gitignore
Expand Up @@ -2,7 +2,7 @@
/test/
/node_modules/
/index.*
/mutation_controller.*
/performance_controller.*
/resize_controller.*
/intersection_controller.*
/mutation-controller.*
/performance-controller.*
/resize-controller.*
/intersection-controller.*
48 changes: 24 additions & 24 deletions packages/labs/observers/package.json
Expand Up @@ -22,35 +22,35 @@
"development": "./development/index.js",
"default": "./index.js"
},
"./mutation_controller.js": {
"types": "./development/mutation_controller.d.ts",
"development": "./development/mutation_controller.js",
"default": "./mutation_controller.js"
"./mutation-controller.js": {
"types": "./development/mutation-controller.d.ts",
"development": "./development/mutation-controller.js",
"default": "./mutation-controller.js"
},
"./performance_controller.js": {
"types": "./development/performance_controller.d.ts",
"development": "./development/performance_controller.js",
"default": "./performance_controller.js"
"./performance-controller.js": {
"types": "./development/performance-controller.d.ts",
"development": "./development/performance-controller.js",
"default": "./performance-controller.js"
},
"./resize_controller.js": {
"types": "./development/resize_controller.d.ts",
"development": "./development/resize_controller.js",
"default": "./resize_controller.js"
"./resize-controller.js": {
"types": "./development/resize-controller.d.ts",
"development": "./development/resize-controller.js",
"default": "./resize-controller.js"
},
"./intersection_controller.js": {
"types": "./development/intersection_controller.d.ts",
"development": "./development/intersection_controller.js",
"default": "./intersection_controller.js"
"./intersection-controller.js": {
"types": "./development/intersection-controller.d.ts",
"development": "./development/intersection-controller.js",
"default": "./intersection-controller.js"
}
},
"files": [
"/development/",
"!/development/test/",
"/index.{d.ts,d.ts.map,js,js.map}",
"/mutation_controller.{d.ts,d.ts.map,js,js.map}",
"/performance_controller.{d.ts,d.ts.map,js,js.map}",
"/resize_controller.{d.ts,d.ts.map,js,js.map}",
"/intersection_controller.{d.ts,d.ts.map,js,js.map}"
"/mutation-controller.{d.ts,d.ts.map,js,js.map}",
"/performance-controller.{d.ts,d.ts.map,js,js.map}",
"/resize-controller.{d.ts,d.ts.map,js,js.map}",
"/intersection-controller.{d.ts,d.ts.map,js,js.map}"
],
"scripts": {
"build": "wireit",
Expand Down Expand Up @@ -109,10 +109,10 @@
],
"output": [
"index.js{,.map}",
"intersection_controller.js{,.map}",
"mutation_controller.js{,.map}",
"performance_controller.js{,.map}",
"resize_controller.js{,.map}",
"intersection-controller.js{,.map}",
"mutation-controller.js{,.map}",
"performance-controller.js{,.map}",
"resize-controller.js{,.map}",
"test/**/*.js{,.map}"
]
},
Expand Down
8 changes: 4 additions & 4 deletions packages/labs/observers/rollup.config.js
Expand Up @@ -11,10 +11,10 @@ export default litProdConfig({
packageName: createRequire(import.meta.url)('./package.json').name,
entryPoints: [
'index',
'mutation_controller',
'resize_controller',
'intersection_controller',
'performance_controller',
'mutation-controller',
'resize-controller',
'intersection-controller',
'performance-controller',
],
external: ['@lit/reactive-element'],
});
Expand Up @@ -13,7 +13,7 @@ import {
IntersectionController,
IntersectionControllerConfig,
IntersectionValueCallback,
} from '@lit-labs/observers/intersection_controller.js';
} from '@lit-labs/observers/intersection-controller.js';
import {generateElementName, nextFrame} from './test-helpers.js';
import {assert} from '@esm-bundle/chai';

Expand Down
Expand Up @@ -13,7 +13,7 @@ import {
MutationController,
MutationControllerConfig,
MutationValueCallback,
} from '@lit-labs/observers/mutation_controller.js';
} from '@lit-labs/observers/mutation-controller.js';
import {generateElementName, nextFrame} from './test-helpers.js';
import {assert} from '@esm-bundle/chai';

Expand Down
Expand Up @@ -13,7 +13,7 @@ import {
PerformanceController,
PerformanceControllerConfig,
PerformanceValueCallback,
} from '@lit-labs/observers/performance_controller.js';
} from '@lit-labs/observers/performance-controller.js';
import {generateElementName, nextFrame} from './test-helpers.js';
import {assert} from '@esm-bundle/chai';

Expand Down
Expand Up @@ -13,7 +13,7 @@ import {
ResizeController,
ResizeControllerConfig,
ResizeValueCallback,
} from '@lit-labs/observers/resize_controller.js';
} from '@lit-labs/observers/resize-controller.js';
import {generateElementName, nextFrame} from './test-helpers.js';
import {assert} from '@esm-bundle/chai';

Expand Down Expand Up @@ -474,7 +474,7 @@ if (DEV_MODE) {
// This test only checks compile-type behavior. There are no runtime checks.
const el = await getTestElement();
const A = new ResizeController<number>(el, {
// @ts-expect-error Type 'string' is not assignable to type 'number'
// @ts-expect-error Type 'number' is not assignable to type 'string'
callback: () => '',
});
if (A) {
Expand All @@ -484,11 +484,11 @@ if (DEV_MODE) {
const B = new ResizeController(el, {
callback: () => '',
});
// @ts-expect-error Type 'number' is not assignable to type 'string'.
// @ts-expect-error Type 'number' is not assignable to type 'string'
B.value = 2;

const C = new ResizeController(el, {}) as ResizeController<string>;
// @ts-expect-error Type 'number' is not assignable to type 'string'.
// @ts-expect-error Type 'number' is not assignable to type 'string'
C.value = 3;

const narrowTypeCb: ResizeValueCallback<string | null> = () => '';
Expand Down

0 comments on commit 89da3d8

Please sign in to comment.