Skip to content

Commit

Permalink
[tests] Skip ElementInternals SSR integration tests in Safari (#3744)
Browse files Browse the repository at this point in the history
  • Loading branch information
augustjk committed Mar 21, 2023
1 parent da3b8d5 commit fd713c0
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .changeset/fuzzy-glasses-study.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
12 changes: 12 additions & 0 deletions packages/labs/ssr/src/test/integration/tests/basic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5188,6 +5188,12 @@ export const tests: {[name: string]: SSRTest} = {

'LitElement: ElementInternals': () => {
return {
// ElementInternals is not implemented in Safari yet
skip: Boolean(
globalThis.navigator &&
navigator.userAgent.includes('Safari/') &&
navigator.userAgent.includes('Version/')
),
registerElements() {
class LEInternals extends LitElement {
constructor() {
Expand Down Expand Up @@ -5225,6 +5231,12 @@ export const tests: {[name: string]: SSRTest} = {

'LitElement: ElementInternals with hydration': () => {
return {
// ElementInternals is not implemented in Safari yet
skip: Boolean(
globalThis.navigator &&
navigator.userAgent.includes('Safari/') &&
navigator.userAgent.includes('Version/')
),
registerElements() {
class LEInternalsHydrate extends LitElement {
internals;
Expand Down
2 changes: 1 addition & 1 deletion packages/tests/src/web-test-runner.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const browserPresets = {
// Many browser configurations don't yet work with @web/test-runner-saucelabs.
// See https://github.com/modernweb-dev/web/issues/472.
sauce: [
'sauce:Windows 10/Firefox@91', // Current ESR. See: https://wiki.mozilla.org/Release_Management/Calendar
'sauce:Windows 10/Firefox@102', // Current ESR. See: https://wiki.mozilla.org/Release_Management/Calendar
'sauce:Windows 10/Chrome@latest-2',
'sauce:macOS 11/Safari@latest',
// 'sauce:Windows 10/MicrosoftEdge@18', // needs globalThis polyfill
Expand Down

0 comments on commit fd713c0

Please sign in to comment.