Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[labs/ssr-client] Bump dependency for requisite version of lit-html #3899

Closed
1 task done
augustjk opened this issue May 12, 2023 · 0 comments · Fixed by #3901
Closed
1 task done

[labs/ssr-client] Bump dependency for requisite version of lit-html #3899

augustjk opened this issue May 12, 2023 · 0 comments · Fixed by #3901
Assignees
@augustjk

Comments

@augustjk
Copy link
Member

augustjk commented May 12, 2023 •
edited

Should this be an RFC?

  • This is not a substantial change

Which package is this a feature request for?

Other/unknown (please mention in description)

Description

#3720 moved SSR hydration modules to labs/ssr-client but that also required changes to lit-html for the shared private hydration support objects.

We should add a dependency semver with lit-html@2.7.1 as minimum so users using labs/ssr-client will know if they have an incompatible version of lit-html.

Many thanks to @AndrewJakubowicz for finding and suggesting this.

Alternatives and Workarounds

Update lit-html manually.
@augustjk augustjk self-assigned this May 12, 2023
@augustjk augustjk changed the title [labs/ssr-client] Add peer dependency for requisite version of lit-html [labs/ssr-client] Bump dependency for requisite version of lit-html May 12, 2023
@augustjk augustjk mentioned this issue May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@augustjk augustjk

Labels
None yet
Projects
Lit Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[labs/ssr-client] Bump lit-html dependency version lit/lit
1 participant
@augustjk