Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[labs/ssr-client] Bump lit-html dependency version #3901

Merged
merged 2 commits into from May 12, 2023
Merged

Conversation

augustjk
Copy link
Member

Fixes #3899

This dependency bump ensures users have the needed version of lit-html installed for hydration code to work.

@changeset-bot
Copy link

changeset-bot bot commented May 12, 2023

🦋 Changeset detected

Latest commit: f327189

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/ssr-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2023

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -5% - +7% (-0.82ms - +1.22ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 76.20ms - 79.35ms
  • lit-html-kitchen-sink: unsure 🔍 -7% - +5% (-2.29ms - +1.70ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -8% - +5% (-0.83ms - +0.53ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -4% - +2% (-2.27ms - +1.18ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +4% (-1.28ms - +1.98ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 863.95ms - 872.02ms
  • lit-html-kitchen-sink: unsure 🔍 -3% - +6% (-2.68ms - +4.76ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +6% (-2.24ms - +16.70ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +2% (-0.87ms - +1.98ms)
    this-change vs tip-of-tree
  • reactive-element-list: slower ❌ 0% - 1% (0.79ms - 10.39ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 825.84ms - 834.68ms
  • reactive-element-list: unsure 🔍 -0% - +1% (-1.82ms - +7.02ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
76.20ms - 79.35ms-

update

VersionAvg timevs
863.95ms - 872.02ms-

update-reflect

VersionAvg timevs
825.84ms - 834.68ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
30.10ms - 33.01ms-unsure 🔍
-7% - +5%
-2.29ms - +1.70ms
unsure 🔍
-7% - +4%
-2.39ms - +1.40ms
tip-of-tree
tip-of-tree
30.48ms - 33.21msunsure 🔍
-5% - +7%
-1.70ms - +2.29ms
-unsure 🔍
-6% - +5%
-2.03ms - +1.63ms
previous-release
previous-release
30.83ms - 33.26msunsure 🔍
-4% - +8%
-1.40ms - +2.39ms
unsure 🔍
-5% - +6%
-1.63ms - +2.03ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
82.44ms - 88.38ms-unsure 🔍
-3% - +6%
-2.68ms - +4.76ms
unsure 🔍
-5% - +4%
-4.26ms - +3.28ms
tip-of-tree
tip-of-tree
82.14ms - 86.61msunsure 🔍
-6% - +3%
-4.76ms - +2.68ms
-unsure 🔍
-5% - +2%
-4.75ms - +1.69ms
previous-release
previous-release
83.59ms - 88.22msunsure 🔍
-4% - +5%
-3.28ms - +4.26ms
unsure 🔍
-2% - +6%
-1.69ms - +4.75ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
16.60ms - 17.92ms-unsure 🔍
-5% - +7%
-0.82ms - +1.22ms
unsure 🔍
-5% - +7%
-0.79ms - +1.18ms
tip-of-tree
tip-of-tree
16.29ms - 17.83msunsure 🔍
-7% - +5%
-1.22ms - +0.82ms
-unsure 🔍
-6% - +6%
-1.07ms - +1.06ms
previous-release
previous-release
16.33ms - 17.79msunsure 🔍
-7% - +5%
-1.18ms - +0.79ms
unsure 🔍
-6% - +6%
-1.06ms - +1.07ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.20ms - 11.16ms-unsure 🔍
-8% - +5%
-0.83ms - +0.53ms
unsure 🔍
-10% - +2%
-1.13ms - +0.18ms
tip-of-tree
tip-of-tree
10.35ms - 11.31msunsure 🔍
-5% - +8%
-0.53ms - +0.83ms
-unsure 🔍
-9% - +3%
-0.98ms - +0.33ms
previous-release
previous-release
10.70ms - 11.60msunsure 🔍
-2% - +11%
-0.18ms - +1.13ms
unsure 🔍
-3% - +9%
-0.33ms - +0.98ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
283.51ms - 296.44ms-unsure 🔍
-1% - +6%
-2.24ms - +16.70ms
unsure 🔍
-2% - +4%
-4.67ms - +12.03ms
tip-of-tree
tip-of-tree
275.82ms - 289.67msunsure 🔍
-6% - +1%
-16.70ms - +2.24ms
-unsure 🔍
-4% - +2%
-12.26ms - +5.17ms
previous-release
previous-release
281.00ms - 291.59msunsure 🔍
-4% - +2%
-12.03ms - +4.67ms
unsure 🔍
-2% - +4%
-5.17ms - +12.26ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
55.97ms - 58.19ms-unsure 🔍
-4% - +2%
-2.27ms - +1.18ms
unsure 🔍
-5% - +1%
-2.78ms - +0.66ms
tip-of-tree
tip-of-tree
56.31ms - 58.95msunsure 🔍
-2% - +4%
-1.18ms - +2.27ms
-unsure 🔍
-4% - +2%
-2.37ms - +1.35ms
previous-release
previous-release
56.83ms - 59.45msunsure 🔍
-1% - +5%
-0.66ms - +2.78ms
unsure 🔍
-2% - +4%
-1.35ms - +2.37ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
123.56ms - 125.54ms-unsure 🔍
-1% - +2%
-0.87ms - +1.98ms
unsure 🔍
-2% - +1%
-1.93ms - +1.55ms
tip-of-tree
tip-of-tree
122.97ms - 125.02msunsure 🔍
-2% - +1%
-1.98ms - +0.87ms
-unsure 🔍
-2% - +1%
-2.50ms - +1.01ms
previous-release
previous-release
123.32ms - 126.17msunsure 🔍
-1% - +2%
-1.55ms - +1.93ms
unsure 🔍
-1% - +2%
-1.01ms - +2.50ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
50.71ms - 52.99ms-unsure 🔍
-2% - +4%
-1.28ms - +1.98ms
unsure 🔍
-4% - +2%
-2.04ms - +0.90ms
tip-of-tree
tip-of-tree
50.34ms - 52.66msunsure 🔍
-4% - +2%
-1.98ms - +1.28ms
-unsure 🔍
-5% - +1%
-2.40ms - +0.57ms
previous-release
previous-release
51.49ms - 53.34msunsure 🔍
-2% - +4%
-0.90ms - +2.04ms
unsure 🔍
-1% - +5%
-0.57ms - +2.40ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
930.08ms - 936.05ms-slower ❌
0% - 1%
0.79ms - 10.39ms
unsure 🔍
-0% - +1%
-2.36ms - +6.88ms
tip-of-tree
tip-of-tree
923.71ms - 931.23msfaster ✔
0% - 1%
0.79ms - 10.39ms
-unsure 🔍
-1% - +0%
-8.49ms - +1.82ms
previous-release
previous-release
927.28ms - 934.33msunsure 🔍
-1% - +0%
-6.88ms - +2.36ms
unsure 🔍
-0% - +1%
-1.82ms - +8.49ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
908.02ms - 913.82ms-unsure 🔍
-0% - +1%
-1.82ms - +7.02ms
unsure 🔍
-0% - +1%
-3.01ms - +5.59ms
tip-of-tree
tip-of-tree
904.99ms - 911.66msunsure 🔍
-1% - +0%
-7.02ms - +1.82ms
-unsure 🔍
-1% - +0%
-5.91ms - +3.30ms
previous-release
previous-release
906.46ms - 912.80msunsure 🔍
-1% - +0%
-5.59ms - +3.01ms
unsure 🔍
-0% - +1%
-3.30ms - +5.91ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

@augustjk augustjk merged commit 82e9f37 into main May 12, 2023
7 checks passed
@augustjk augustjk deleted the ssr-client-peer-dep branch May 12, 2023 23:11
This was referenced May 24, 2023
@lit-robot lit-robot mentioned this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[labs/ssr-client] Bump dependency for requisite version of lit-html
2 participants