Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Version Packages (#3506)" #3507

Merged
merged 1 commit into from Dec 8, 2022
Merged

Revert "Version Packages (#3506)" #3507

merged 1 commit into from Dec 8, 2022

Conversation

augustjk
Copy link
Member

@augustjk augustjk commented Dec 8, 2022

This reverts commit 5c83a35.

The Github actions for changesets does not handle switching between creating a version and publishing when there are leftover changeset files due to using the "ignore" option. Reverting this release for now.

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2022

🦋 Changeset detected

Latest commit: dec843a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@lit-labs/context Minor
@lit-labs/analyzer Minor
@lit-labs/gen-manifest Minor
@lit-labs/ssr Minor
@lit-labs/cli Minor
lit-html Minor
@lit/reactive-element Minor
lit Minor
@lit-labs/react Patch
@lit-labs/gen-utils Minor
@lit-labs/gen-wrapper-angular Patch
@lit-labs/gen-wrapper-react Patch
@lit-labs/gen-wrapper-vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -1% - +4% (-0.32ms - +0.90ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 83.85ms - 88.91ms
  • lit-html-kitchen-sink: unsure 🔍 -1% - +8% (-0.36ms - +2.59ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -8% - +1% (-0.93ms - +0.10ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +2% (-0.69ms - +1.34ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -5% - +1% (-2.93ms - +0.63ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 786.50ms - 798.62ms
  • lit-html-kitchen-sink: unsure 🔍 -4% - +2% (-3.68ms - +1.54ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +1% (-7.49ms - +4.18ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +0% (-2.73ms - +0.50ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-4.30ms - +6.98ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 786.08ms - 791.61ms
  • reactive-element-list: unsure 🔍 -1% - +1% (-4.58ms - +5.42ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
83.85ms - 88.91ms-

update

VersionAvg timevs
786.50ms - 798.62ms-

update-reflect

VersionAvg timevs
786.08ms - 791.61ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
32.24ms - 34.49ms-unsure 🔍
-1% - +8%
-0.36ms - +2.59ms
unsure 🔍
-0% - +9%
-0.02ms - +2.80ms
tip-of-tree
tip-of-tree
31.29ms - 33.21msunsure 🔍
-8% - +1%
-2.59ms - +0.36ms
-unsure 🔍
-3% - +5%
-1.01ms - +1.56ms
previous-release
previous-release
31.12ms - 32.83msunsure 🔍
-8% - -0%
-2.80ms - +0.02ms
unsure 🔍
-5% - +3%
-1.56ms - +1.01ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
84.69ms - 88.79ms-unsure 🔍
-4% - +2%
-3.68ms - +1.54ms
unsure 🔍
-3% - +4%
-2.43ms - +3.21ms
tip-of-tree
tip-of-tree
86.19ms - 89.43msunsure 🔍
-2% - +4%
-1.54ms - +3.68ms
-unsure 🔍
-1% - +5%
-1.07ms - +3.99ms
previous-release
previous-release
84.41ms - 88.29msunsure 🔍
-4% - +3%
-3.21ms - +2.43ms
unsure 🔍
-5% - +1%
-3.99ms - +1.07ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
22.73ms - 23.70ms-unsure 🔍
-1% - +4%
-0.32ms - +0.90ms
unsure 🔍
-2% - +4%
-0.56ms - +0.86ms
tip-of-tree
tip-of-tree
22.55ms - 23.30msunsure 🔍
-4% - +1%
-0.90ms - +0.32ms
-unsure 🔍
-3% - +2%
-0.79ms - +0.51ms
previous-release
previous-release
22.54ms - 23.59msunsure 🔍
-4% - +2%
-0.86ms - +0.56ms
unsure 🔍
-2% - +3%
-0.51ms - +0.79ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
11.46ms - 12.21ms-unsure 🔍
-8% - +1%
-0.93ms - +0.10ms
unsure 🔍
-6% - +3%
-0.76ms - +0.34ms
tip-of-tree
tip-of-tree
11.90ms - 12.60msunsure 🔍
-1% - +8%
-0.10ms - +0.93ms
-unsure 🔍
-3% - +6%
-0.32ms - +0.74ms
previous-release
previous-release
11.64ms - 12.44msunsure 🔍
-3% - +6%
-0.34ms - +0.76ms
unsure 🔍
-6% - +3%
-0.74ms - +0.32ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
300.62ms - 308.67ms-unsure 🔍
-2% - +1%
-7.49ms - +4.18ms
unsure 🔍
-4% - +0%
-11.22ms - +0.64ms
tip-of-tree
tip-of-tree
302.08ms - 310.52msunsure 🔍
-1% - +2%
-4.18ms - +7.49ms
-unsure 🔍
-3% - +1%
-9.70ms - +2.44ms
previous-release
previous-release
305.57ms - 314.29msunsure 🔍
-0% - +4%
-0.64ms - +11.22ms
unsure 🔍
-1% - +3%
-2.44ms - +9.70ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
55.06ms - 56.64ms-unsure 🔍
-1% - +2%
-0.69ms - +1.34ms
unsure 🔍
-3% - +1%
-1.71ms - +0.61ms
tip-of-tree
tip-of-tree
54.88ms - 56.16msunsure 🔍
-2% - +1%
-1.34ms - +0.69ms
-unsure 🔍
-3% - +0%
-1.95ms - +0.18ms
previous-release
previous-release
55.55ms - 57.25msunsure 🔍
-1% - +3%
-0.61ms - +1.71ms
unsure 🔍
-0% - +4%
-0.18ms - +1.95ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
118.96ms - 120.97ms-unsure 🔍
-2% - +0%
-2.73ms - +0.50ms
unsure 🔍
-2% - +1%
-2.13ms - +0.79ms
tip-of-tree
tip-of-tree
119.82ms - 122.34msunsure 🔍
-0% - +2%
-0.50ms - +2.73ms
-unsure 🔍
-1% - +2%
-1.20ms - +2.08ms
previous-release
previous-release
119.58ms - 121.69msunsure 🔍
-1% - +2%
-0.79ms - +2.13ms
unsure 🔍
-2% - +1%
-2.08ms - +1.20ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
54.30ms - 56.46ms-unsure 🔍
-5% - +1%
-2.93ms - +0.63ms
unsure 🔍
-3% - +2%
-1.89ms - +1.10ms
tip-of-tree
tip-of-tree
55.12ms - 57.94msunsure 🔍
-1% - +5%
-0.63ms - +2.93ms
-unsure 🔍
-2% - +5%
-0.99ms - +2.50ms
previous-release
previous-release
54.74ms - 56.81msunsure 🔍
-2% - +3%
-1.10ms - +1.89ms
unsure 🔍
-4% - +2%
-2.50ms - +0.99ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
803.80ms - 810.48ms-unsure 🔍
-1% - +1%
-4.30ms - +6.98ms
unsure 🔍
-1% - +0%
-8.23ms - +1.61ms
tip-of-tree
tip-of-tree
801.25ms - 810.35msunsure 🔍
-1% - +1%
-6.98ms - +4.30ms
-unsure 🔍
-1% - +0%
-10.46ms - +1.16ms
previous-release
previous-release
806.84ms - 814.05msunsure 🔍
-0% - +1%
-1.61ms - +8.23ms
unsure 🔍
-0% - +1%
-1.16ms - +10.46ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
822.40ms - 828.70ms-unsure 🔍
-1% - +1%
-4.58ms - +5.42ms
unsure 🔍
-0% - +1%
-3.73ms - +6.06ms
tip-of-tree
tip-of-tree
821.25ms - 829.02msunsure 🔍
-1% - +1%
-5.42ms - +4.58ms
-unsure 🔍
-1% - +1%
-4.65ms - +6.14ms
previous-release
previous-release
820.64ms - 828.13msunsure 🔍
-1% - +0%
-6.06ms - +3.73ms
unsure 🔍
-1% - +1%
-6.14ms - +4.65ms
-

tachometer-reporter-action v2 for Benchmarks

@augustjk augustjk merged commit b152db2 into main Dec 8, 2022
@augustjk augustjk deleted the revert-changeset branch December 8, 2022 01:45
@augustjk
Copy link
Member Author

augustjk commented Dec 8, 2022

Related issue
changesets/action#241

This was referenced Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants