Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[labs/ssr-dom-shim] Add basic support for element internals #3677

Merged
merged 16 commits into from Mar 21, 2023
Merged

[labs/ssr-dom-shim] Add basic support for element internals #3677

merged 16 commits into from Mar 21, 2023

Commits on Mar 11, 2023

  1. [labs/ssr-dom-shim] Add basic support for element internals 

    * Add a rough implementation for ElementShim.prototype.attachInternals
Fixes lit#3676
    @calebdwilliams @augustjk
    calebdwilliams authored and augustjk committed Mar 11, 2023
    Copy the full SHA
    cba3c95 View commit details
    Browse the repository at this point in the history

  2. chore: add changeset

    @calebdwilliams @augustjk
    calebdwilliams authored and augustjk committed Mar 11, 2023
    Copy the full SHA
    49b7387 View commit details
    Browse the repository at this point in the history

  3. test: add tests for element internals integration

    @calebdwilliams @augustjk
    calebdwilliams authored and augustjk committed Mar 11, 2023
    Copy the full SHA
    fbaa901 View commit details
    Browse the repository at this point in the history

  4. chore: clear up semantics on the internals element

    @calebdwilliams @augustjk
    calebdwilliams authored and augustjk committed Mar 11, 2023
    Copy the full SHA
    3684584 View commit details
    Browse the repository at this point in the history

  5. chore: address code changes

    @calebdwilliams @augustjk
    calebdwilliams authored and augustjk committed Mar 11, 2023
    Copy the full SHA
    94a1b81 View commit details
    Browse the repository at this point in the history

  6. chore: address PR feedback

    @calebdwilliams @augustjk
    calebdwilliams authored and augustjk committed Mar 11, 2023
    Copy the full SHA
    c1d6b27 View commit details
    Browse the repository at this point in the history

  7. chore: address code review feedback

    @calebdwilliams @augustjk
    calebdwilliams authored and augustjk committed Mar 11, 2023
    Copy the full SHA
    2d9d094 View commit details
    Browse the repository at this point in the history

  8. chore: continue work on element internals feature

    @calebdwilliams @augustjk
    calebdwilliams authored and augustjk committed Mar 11, 2023
    Copy the full SHA
    f138ee6 View commit details
    Browse the repository at this point in the history

  9. Add ability skip pre-hydration assertHTML

    @augustjk
    augustjk committed Mar 11, 2023
    Copy the full SHA
    e8f93cf View commit details
    Browse the repository at this point in the history

  10. Remove attrs added by internals shim during hydration

    @augustjk
    augustjk committed Mar 11, 2023
    Copy the full SHA
    eeb1513 View commit details
    Browse the repository at this point in the history

  11. Update le-internals-hydrate test

    @augustjk
    augustjk committed Mar 11, 2023
    Copy the full SHA
    f3b1779 View commit details
    Browse the repository at this point in the history

  12. Add element-internals to package configs

    @augustjk
    augustjk committed Mar 11, 2023
    Copy the full SHA
    bfec6b4 View commit details
    Browse the repository at this point in the history

  13. Clean up ElementInternalsShim 

    - Put element-internals file under lib/ and export out of index
- Augment ARIAMixin interface
- Export const for hydrate-internals- prefix
    @augustjk
    augustjk committed Mar 11, 2023
    Copy the full SHA
    d581707 View commit details
    Browse the repository at this point in the history

  14. Update SSR and hydrate-support to use const prefix

    @augustjk
    augustjk committed Mar 11, 2023
    Copy the full SHA
    88038e5 View commit details
    Browse the repository at this point in the history

  15. Update changeset and add one for aria attr reflection

    @augustjk
    augustjk committed Mar 11, 2023
    Copy the full SHA
    dcef2b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Address review comments 

    - Throw on repeat call to `attachInternals()`.
- Add warning for `checkValidity()` calls.
- Retype and rename `ariaMixinEnum` to `ariaMixinAttributes`.
- Loop through ariaAttrMap instead of internals instance.
    @augustjk
    augustjk committed Mar 21, 2023
    Copy the full SHA
    056a39c View commit details
    Browse the repository at this point in the history