Skip to content

Remove Lit 1 -> Lit 2 migration warnings #3762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

justinfagnani
Copy link
Collaborator

These are all dev mode things, but I think it's good to clean this up too so we don't collect cruft over time. Less code is easier to maintain.

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2023

🦋 Changeset detected

Latest commit: be34262

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 29 packages
Name Type
@lit/reactive-element Patch
lit-element Patch
lit-html Patch
lit Patch
@lit-internal/benchmarks Patch
@lit/localize Patch
@lit-labs/context Patch
@lit-labs/observers Patch
@lit-labs/scoped-registry-mixin Patch
@lit-labs/ssr-client Patch
@lit-labs/ssr Patch
@lit-labs/task Patch
@lit/lit-starter-js Patch
@lit/lit-starter-ts Patch
@lit/localize-tools Patch
@lit-labs/eleventy-plugin-lit Patch
@lit-labs/motion Patch
@lit-labs/router Patch
@lit-labs/ssr-react Patch
@lit-labs/testing Patch
@lit-labs/virtualizer Patch
@lit-internal/test-element-a Patch
@lit-internal/localize-examples-runtime-js Patch
@lit-internal/localize-examples-runtime-ts Patch
@lit-internal/localize-examples-transform-js Patch
@lit-internal/localize-examples-transform-ts Patch
@lit-labs/cli-localize Patch
@lit-labs/cli Patch
@lit-labs/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -6% - +3% (-1.17ms - +0.63ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 103.72ms - 109.76ms
  • lit-html-kitchen-sink: unsure 🔍 -7% - +5% (-3.32ms - +2.41ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -20% - +1% (-3.03ms - +0.29ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -4% - +1% (-3.03ms - +0.41ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -5% - +1% (-3.54ms - +0.58ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 1048.38ms - 1068.33ms
  • lit-html-kitchen-sink: unsure 🔍 -6% - +2% (-6.48ms - +2.23ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -4% - +2% (-13.55ms - +6.69ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +2% (-2.80ms - +3.35ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +1% (-24.84ms - +8.60ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 1023.13ms - 1043.35ms
  • reactive-element-list: unsure 🔍 -1% - +1% (-15.38ms - +11.63ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
103.72ms - 109.76ms-

update

VersionAvg timevs
1048.38ms - 1068.33ms-

update-reflect

VersionAvg timevs
1023.13ms - 1043.35ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
42.72ms - 45.97ms-unsure 🔍
-7% - +5%
-3.32ms - +2.41ms
unsure 🔍
-4% - +5%
-1.68ms - +2.40ms
tip-of-tree
tip-of-tree
42.44ms - 47.17msunsure 🔍
-5% - +8%
-2.41ms - +3.32ms
-unsure 🔍
-4% - +8%
-1.85ms - +3.49ms
previous-release
previous-release
42.75ms - 45.22msunsure 🔍
-5% - +4%
-2.40ms - +1.68ms
unsure 🔍
-8% - +4%
-3.49ms - +1.85ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
104.07ms - 109.73ms-unsure 🔍
-6% - +2%
-6.48ms - +2.23ms
unsure 🔍
-5% - +2%
-5.95ms - +1.73ms
tip-of-tree
tip-of-tree
105.71ms - 112.33msunsure 🔍
-2% - +6%
-2.23ms - +6.48ms
-unsure 🔍
-4% - +4%
-4.19ms - +4.22ms
previous-release
previous-release
106.41ms - 111.60msunsure 🔍
-2% - +6%
-1.73ms - +5.95ms
unsure 🔍
-4% - +4%
-4.22ms - +4.19ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
19.86ms - 21.04ms-unsure 🔍
-6% - +3%
-1.17ms - +0.63ms
unsure 🔍
-4% - +7%
-0.78ms - +1.32ms
tip-of-tree
tip-of-tree
20.05ms - 21.40msunsure 🔍
-3% - +6%
-0.63ms - +1.17ms
-unsure 🔍
-3% - +8%
-0.56ms - +1.64ms
previous-release
previous-release
19.32ms - 21.05msunsure 🔍
-6% - +4%
-1.32ms - +0.78ms
unsure 🔍
-8% - +3%
-1.64ms - +0.56ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
12.70ms - 14.08ms-unsure 🔍
-20% - +1%
-3.03ms - +0.29ms
unsure 🔍
-12% - +2%
-1.79ms - +0.27ms
tip-of-tree
tip-of-tree
13.26ms - 16.27msunsure 🔍
-2% - +23%
-0.29ms - +3.03ms
-unsure 🔍
-8% - +16%
-1.08ms - +2.30ms
previous-release
previous-release
13.39ms - 14.92msunsure 🔍
-2% - +14%
-0.27ms - +1.79ms
unsure 🔍
-15% - +7%
-2.30ms - +1.08ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
338.58ms - 352.69ms-unsure 🔍
-4% - +2%
-13.55ms - +6.69ms
unsure 🔍
-6% - +1%
-20.11ms - +3.08ms
tip-of-tree
tip-of-tree
341.81ms - 356.33msunsure 🔍
-2% - +4%
-6.69ms - +13.55ms
-unsure 🔍
-5% - +2%
-16.81ms - +6.64ms
previous-release
previous-release
344.95ms - 363.36msunsure 🔍
-1% - +6%
-3.08ms - +20.11ms
unsure 🔍
-2% - +5%
-6.64ms - +16.81ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
67.49ms - 69.74ms-unsure 🔍
-4% - +1%
-3.03ms - +0.41ms
unsure 🔍
-4% - +2%
-2.67ms - +1.12ms
tip-of-tree
tip-of-tree
68.62ms - 71.23msunsure 🔍
-1% - +4%
-0.41ms - +3.03ms
-unsure 🔍
-2% - +4%
-1.47ms - +2.54ms
previous-release
previous-release
67.87ms - 70.91msunsure 🔍
-2% - +4%
-1.12ms - +2.67ms
unsure 🔍
-4% - +2%
-2.54ms - +1.47ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
145.55ms - 150.04ms-unsure 🔍
-2% - +2%
-2.80ms - +3.35ms
unsure 🔍
-3% - +2%
-4.27ms - +3.09ms
tip-of-tree
tip-of-tree
145.42ms - 149.62msunsure 🔍
-2% - +2%
-3.35ms - +2.80ms
-unsure 🔍
-3% - +2%
-4.45ms - +2.73ms
previous-release
previous-release
145.47ms - 151.30msunsure 🔍
-2% - +3%
-3.09ms - +4.27ms
unsure 🔍
-2% - +3%
-2.73ms - +4.45ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
67.75ms - 70.55ms-unsure 🔍
-5% - +1%
-3.54ms - +0.58ms
unsure 🔍
-5% - +0%
-3.70ms - +0.05ms
tip-of-tree
tip-of-tree
69.12ms - 72.14msunsure 🔍
-1% - +5%
-0.58ms - +3.54ms
-unsure 🔍
-3% - +2%
-2.30ms - +1.61ms
previous-release
previous-release
69.73ms - 72.22msunsure 🔍
-0% - +5%
-0.05ms - +3.70ms
unsure 🔍
-2% - +3%
-1.61ms - +2.30ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1064.91ms - 1092.24ms-unsure 🔍
-2% - +1%
-24.84ms - +8.60ms
unsure 🔍
-1% - +2%
-7.28ms - +24.70ms
tip-of-tree
tip-of-tree
1077.06ms - 1096.33msunsure 🔍
-1% - +2%
-8.60ms - +24.84ms
-slower ❌
0% - 3%
4.11ms - 29.55ms
previous-release
previous-release
1061.56ms - 1078.17msunsure 🔍
-2% - +1%
-24.70ms - +7.28ms
faster ✔
0% - 3%
4.11ms - 29.55ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1063.65ms - 1081.73ms-unsure 🔍
-1% - +1%
-15.38ms - +11.63ms
unsure 🔍
-1% - +2%
-7.12ms - +16.01ms
tip-of-tree
tip-of-tree
1064.53ms - 1084.60msunsure 🔍
-1% - +1%
-11.63ms - +15.38ms
-unsure 🔍
-1% - +2%
-6.04ms - +18.68ms
previous-release
previous-release
1061.04ms - 1075.45msunsure 🔍
-1% - +1%
-16.01ms - +7.12ms
unsure 🔍
-2% - +1%
-18.68ms - +6.04ms
-

tachometer-reporter-action v2 for Benchmarks

@justinfagnani justinfagnani merged commit 23c404f into 3.0 Mar 24, 2023
@justinfagnani justinfagnani deleted the 3.0-remove-warnings branch March 24, 2023 22:25
This was referenced Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants