Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Remove experimental hydration modules #3765

Merged
merged 5 commits into from Apr 5, 2023

Conversation

augustjk
Copy link
Member

@augustjk augustjk commented Mar 27, 2023

Removes exprimental hydrate modules from lit-element, lit-hteml, and lit.

@changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2023

🦋 Changeset detected

Latest commit: 19fb8ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
lit-element Major
lit-html Major
lit Major
@lit-internal/benchmarks Patch
@lit-labs/ssr Patch
@lit-labs/ssr-client Patch
@lit/lit-starter-js Patch
@lit/lit-starter-ts Patch
@lit/localize-tools Patch
@lit/localize Patch
@lit-labs/context Patch
@lit-labs/eleventy-plugin-lit Patch
@lit-labs/motion Patch
@lit-labs/router Patch
@lit-labs/scoped-registry-mixin Patch
@lit-labs/ssr-react Patch
@lit-labs/testing Patch
@lit-labs/virtualizer Patch
@lit-internal/test-element-a Patch
@lit-internal/localize-examples-runtime-js Patch
@lit-internal/localize-examples-runtime-ts Patch
@lit-internal/localize-examples-transform-js Patch
@lit-internal/localize-examples-transform-ts Patch
@lit-labs/cli-localize Patch
@lit-labs/cli Patch
@lit-labs/nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -6% - +8% (-0.95ms - +1.31ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 73.30ms - 76.87ms
  • lit-html-kitchen-sink: unsure 🔍 -9% - +5% (-2.95ms - +1.74ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -7% - +5% (-0.79ms - +0.54ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +4% (-0.53ms - +1.93ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -3% - +2% (-1.76ms - +1.26ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 654.36ms - 660.21ms
  • lit-html-kitchen-sink: unsure 🔍 -2% - +5% (-1.34ms - +4.00ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +3% (-4.69ms - +7.50ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +1% (-1.67ms - +1.26ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +0% (-6.34ms - +1.79ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 638.86ms - 643.74ms
  • reactive-element-list: unsure 🔍 -0% - +1% (-2.79ms - +4.99ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
86.55ms - 93.13ms-

update

VersionAvg timevs
855.71ms - 874.54ms-

update-reflect

VersionAvg timevs
818.76ms - 831.54ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
37.50ms - 41.58ms-unsure 🔍
-2% - +11%
-0.71ms - +4.12ms
slower ❌
0% - 13%
0.05ms - 4.79ms
tip-of-tree
tip-of-tree
36.54ms - 39.13msunsure 🔍
-10% - +2%
-4.12ms - +0.71ms
-unsure 🔍
-3% - +7%
-1.06ms - +2.49ms
previous-release
previous-release
35.91ms - 38.33msfaster ✔
0% - 12%
0.05ms - 4.79ms
unsure 🔍
-7% - +3%
-2.49ms - +1.06ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
93.42ms - 100.28ms-unsure 🔍
-0% - +9%
-0.34ms - +7.95ms
unsure 🔍
-3% - +6%
-3.03ms - +5.50ms
tip-of-tree
tip-of-tree
90.73ms - 95.37msunsure 🔍
-8% - +0%
-7.95ms - +0.34ms
-unsure 🔍
-6% - +1%
-6.00ms - +0.86ms
previous-release
previous-release
93.09ms - 98.15msunsure 🔍
-6% - +3%
-5.50ms - +3.03ms
unsure 🔍
-1% - +6%
-0.86ms - +6.00ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
18.15ms - 21.06ms-unsure 🔍
-4% - +13%
-0.79ms - +2.46ms
unsure 🔍
-5% - +12%
-1.01ms - +2.21ms
tip-of-tree
tip-of-tree
18.05ms - 19.49msunsure 🔍
-12% - +4%
-2.46ms - +0.79ms
-unsure 🔍
-6% - +4%
-1.23ms - +0.76ms
previous-release
previous-release
18.32ms - 19.69msunsure 🔍
-11% - +5%
-2.21ms - +1.01ms
unsure 🔍
-4% - +7%
-0.76ms - +1.23ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
12.80ms - 13.92ms-unsure 🔍
-4% - +8%
-0.57ms - +1.03ms
unsure 🔍
-5% - +6%
-0.70ms - +0.85ms
tip-of-tree
tip-of-tree
12.56ms - 13.70msunsure 🔍
-8% - +4%
-1.03ms - +0.57ms
-unsure 🔍
-7% - +5%
-0.94ms - +0.63ms
previous-release
previous-release
12.75ms - 13.82msunsure 🔍
-6% - +5%
-0.85ms - +0.70ms
unsure 🔍
-5% - +7%
-0.63ms - +0.94ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
331.69ms - 343.68ms-unsure 🔍
-2% - +2%
-8.40ms - +7.67ms
unsure 🔍
-2% - +3%
-6.37ms - +9.19ms
tip-of-tree
tip-of-tree
332.70ms - 343.39msunsure 🔍
-2% - +2%
-7.67ms - +8.40ms
-unsure 🔍
-2% - +3%
-5.52ms - +9.07ms
previous-release
previous-release
331.31ms - 341.23msunsure 🔍
-3% - +2%
-9.19ms - +6.37ms
unsure 🔍
-3% - +2%
-9.07ms - +5.52ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
62.72ms - 65.14ms-unsure 🔍
-2% - +6%
-1.32ms - +3.54ms
unsure 🔍
-0% - +5%
-0.18ms - +3.25ms
tip-of-tree
tip-of-tree
60.71ms - 64.93msunsure 🔍
-6% - +2%
-3.54ms - +1.32ms
-unsure 🔍
-3% - +5%
-2.01ms - +2.87ms
previous-release
previous-release
61.17ms - 63.62msunsure 🔍
-5% - +0%
-3.25ms - +0.18ms
unsure 🔍
-5% - +3%
-2.87ms - +2.01ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
128.11ms - 131.33ms-unsure 🔍
-1% - +2%
-1.45ms - +2.75ms
unsure 🔍
-2% - +1%
-2.58ms - +1.64ms
tip-of-tree
tip-of-tree
127.73ms - 130.41msunsure 🔍
-2% - +1%
-2.75ms - +1.45ms
-unsure 🔍
-2% - +1%
-3.03ms - +0.78ms
previous-release
previous-release
128.83ms - 131.55msunsure 🔍
-1% - +2%
-1.64ms - +2.58ms
unsure 🔍
-1% - +2%
-0.78ms - +3.03ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
56.81ms - 59.51ms-unsure 🔍
-3% - +3%
-1.94ms - +2.02ms
unsure 🔍
-4% - +4%
-2.53ms - +2.12ms
tip-of-tree
tip-of-tree
56.67ms - 59.56msunsure 🔍
-3% - +3%
-2.02ms - +1.94ms
-unsure 🔍
-4% - +4%
-2.63ms - +2.13ms
previous-release
previous-release
56.48ms - 60.26msunsure 🔍
-4% - +4%
-2.12ms - +2.53ms
unsure 🔍
-4% - +5%
-2.13ms - +2.63ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
853.81ms - 879.44ms-unsure 🔍
-2% - +2%
-14.85ms - +17.86ms
unsure 🔍
-1% - +2%
-11.46ms - +20.88ms
tip-of-tree
tip-of-tree
854.96ms - 875.28msunsure 🔍
-2% - +2%
-17.86ms - +14.85ms
-unsure 🔍
-1% - +2%
-10.95ms - +17.37ms
previous-release
previous-release
852.05ms - 871.77msunsure 🔍
-2% - +1%
-20.88ms - +11.46ms
unsure 🔍
-2% - +1%
-17.37ms - +10.95ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
845.31ms - 866.59ms-unsure 🔍
-1% - +2%
-10.94ms - +18.64ms
unsure 🔍
-2% - +2%
-13.01ms - +17.41ms
tip-of-tree
tip-of-tree
841.83ms - 862.38msunsure 🔍
-2% - +1%
-18.64ms - +10.94ms
-unsure 🔍
-2% - +2%
-16.60ms - +13.31ms
previous-release
previous-release
842.89ms - 864.61msunsure 🔍
-2% - +2%
-17.41ms - +13.01ms
unsure 🔍
-2% - +2%
-13.31ms - +16.60ms
-

tachometer-reporter-action v2 for Benchmarks

@augustjk augustjk marked this pull request as draft March 27, 2023 23:02
@augustjk augustjk force-pushed the 3.0-remove-hydration-modules branch from c30acc2 to f980944 Compare April 4, 2023 23:49
@augustjk augustjk requested a review from rictic April 4, 2023 23:52
@augustjk augustjk marked this pull request as ready for review April 4, 2023 23:52
Copy link
Collaborator

@rictic rictic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@augustjk augustjk merged commit 92cedaa into 3.0 Apr 5, 2023
6 checks passed
@augustjk augustjk deleted the 3.0-remove-hydration-modules branch April 5, 2023 22:36
This was referenced Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants