Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[labs/ssr-client] Fix for removing @types/web-ie11 dep #3779

Merged
merged 1 commit into from Apr 4, 2023

Conversation

augustjk
Copy link
Member

@augustjk augustjk commented Apr 3, 2023

I brought in #3720 to 3.0 branch by merging in main which broke the build step.

This PR brings in the change done in #3758 to the copied code in labs/ssr-client.

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

⚠️ No Changeset found

Latest commit: 2fb885a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -4% - +3% (-0.79ms - +0.58ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 91.68ms - 95.57ms
  • lit-html-kitchen-sink: unsure 🔍 -7% - +7% (-2.80ms - +2.70ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +11% (-0.23ms - +1.50ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -5% - +2% (-3.19ms - +1.70ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +5% (-0.95ms - +3.17ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 942.22ms - 955.72ms
  • lit-html-kitchen-sink: unsure 🔍 -4% - +3% (-3.78ms - +3.22ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +3% (-6.26ms - +12.30ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -5% - +1% (-6.89ms - +1.45ms)
    this-change vs tip-of-tree
  • reactive-element-list: faster ✔ 0% - 2% (2.50ms - 21.54ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 901.76ms - 912.46ms
  • reactive-element-list: unsure 🔍 -2% - +0% (-15.45ms - +4.50ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
91.68ms - 95.57ms-

update

VersionAvg timevs
942.22ms - 955.72ms-

update-reflect

VersionAvg timevs
901.76ms - 912.46ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
38.47ms - 42.57ms-unsure 🔍
-7% - +7%
-2.80ms - +2.70ms
unsure 🔍
-7% - +9%
-2.60ms - +3.44ms
tip-of-tree
tip-of-tree
38.73ms - 42.41msunsure 🔍
-7% - +7%
-2.70ms - +2.80ms
-unsure 🔍
-6% - +8%
-2.41ms - +3.35ms
previous-release
previous-release
37.88ms - 42.32msunsure 🔍
-8% - +6%
-3.44ms - +2.60ms
unsure 🔍
-8% - +6%
-3.35ms - +2.41ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
99.33ms - 103.95ms-unsure 🔍
-4% - +3%
-3.78ms - +3.22ms
unsure 🔍
-3% - +6%
-3.43ms - +6.07ms
tip-of-tree
tip-of-tree
99.29ms - 104.55msunsure 🔍
-3% - +4%
-3.22ms - +3.78ms
-unsure 🔍
-3% - +7%
-3.31ms - +6.52ms
previous-release
previous-release
96.16ms - 104.46msunsure 🔍
-6% - +3%
-6.07ms - +3.43ms
unsure 🔍
-6% - +3%
-6.52ms - +3.31ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
19.15ms - 19.89ms-unsure 🔍
-4% - +3%
-0.79ms - +0.58ms
unsure 🔍
-5% - +2%
-0.96ms - +0.44ms
tip-of-tree
tip-of-tree
19.04ms - 20.20msunsure 🔍
-3% - +4%
-0.58ms - +0.79ms
-unsure 🔍
-5% - +3%
-0.99ms - +0.68ms
previous-release
previous-release
19.18ms - 20.38msunsure 🔍
-2% - +5%
-0.44ms - +0.96ms
unsure 🔍
-3% - +5%
-0.68ms - +0.99ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
13.59ms - 14.73ms-unsure 🔍
-2% - +11%
-0.23ms - +1.50ms
unsure 🔍
-4% - +9%
-0.48ms - +1.25ms
tip-of-tree
tip-of-tree
12.88ms - 14.18msunsure 🔍
-10% - +2%
-1.50ms - +0.23ms
-unsure 🔍
-8% - +5%
-1.16ms - +0.67ms
previous-release
previous-release
13.13ms - 14.42msunsure 🔍
-9% - +3%
-1.25ms - +0.48ms
unsure 🔍
-5% - +9%
-0.67ms - +1.16ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
351.07ms - 365.11ms-unsure 🔍
-2% - +3%
-6.26ms - +12.30ms
unsure 🔍
-2% - +3%
-7.08ms - +11.71ms
tip-of-tree
tip-of-tree
349.01ms - 361.14msunsure 🔍
-3% - +2%
-12.30ms - +6.26ms
-unsure 🔍
-3% - +2%
-9.41ms - +8.01ms
previous-release
previous-release
349.53ms - 362.02msunsure 🔍
-3% - +2%
-11.71ms - +7.08ms
unsure 🔍
-2% - +3%
-8.01ms - +9.41ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
65.45ms - 69.04ms-unsure 🔍
-5% - +2%
-3.19ms - +1.70ms
unsure 🔍
-6% - +2%
-4.43ms - +1.24ms
tip-of-tree
tip-of-tree
66.33ms - 69.65msunsure 🔍
-3% - +5%
-1.70ms - +3.19ms
-unsure 🔍
-5% - +3%
-3.60ms - +1.90ms
previous-release
previous-release
66.65ms - 71.04msunsure 🔍
-2% - +7%
-1.24ms - +4.43ms
unsure 🔍
-3% - +5%
-1.90ms - +3.60ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
144.68ms - 150.24ms-unsure 🔍
-5% - +1%
-6.89ms - +1.45ms
unsure 🔍
-3% - +2%
-4.95ms - +3.03ms
tip-of-tree
tip-of-tree
147.08ms - 153.29msunsure 🔍
-1% - +5%
-1.45ms - +6.89ms
-unsure 🔍
-2% - +4%
-2.45ms - +5.98ms
previous-release
previous-release
145.56ms - 151.28msunsure 🔍
-2% - +3%
-3.03ms - +4.95ms
unsure 🔍
-4% - +2%
-5.98ms - +2.45ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
61.94ms - 64.90ms-unsure 🔍
-2% - +5%
-0.95ms - +3.17ms
unsure 🔍
-4% - +3%
-2.40ms - +2.00ms
tip-of-tree
tip-of-tree
60.87ms - 63.74msunsure 🔍
-5% - +1%
-3.17ms - +0.95ms
-unsure 🔍
-5% - +1%
-3.49ms - +0.85ms
previous-release
previous-release
61.99ms - 65.25msunsure 🔍
-3% - +4%
-2.00ms - +2.40ms
unsure 🔍
-1% - +6%
-0.85ms - +3.49ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
962.88ms - 975.98ms-faster ✔
0% - 2%
2.50ms - 21.54ms
unsure 🔍
-2% - +0%
-17.00ms - +1.01ms
tip-of-tree
tip-of-tree
974.55ms - 988.35msslower ❌
0% - 2%
2.50ms - 21.54ms
-unsure 🔍
-1% - +1%
-5.24ms - +13.29ms
previous-release
previous-release
971.25ms - 983.60msunsure 🔍
-0% - +2%
-1.01ms - +17.00ms
unsure 🔍
-1% - +1%
-13.29ms - +5.24ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
947.95ms - 961.81ms-unsure 🔍
-2% - +0%
-15.45ms - +4.50ms
unsure 🔍
-1% - +1%
-12.78ms - +6.10ms
tip-of-tree
tip-of-tree
953.18ms - 967.52msunsure 🔍
-0% - +2%
-4.50ms - +15.45ms
-unsure 🔍
-1% - +1%
-7.49ms - +11.75ms
previous-release
previous-release
951.82ms - 964.63msunsure 🔍
-1% - +1%
-6.10ms - +12.78ms
unsure 🔍
-1% - +1%
-11.75ms - +7.49ms
-

tachometer-reporter-action v2 for Benchmarks

@augustjk augustjk added the 3.0 label Apr 4, 2023
@augustjk augustjk merged commit 5db7efd into 3.0 Apr 4, 2023
6 checks passed
@augustjk augustjk deleted the 3.0-fix-hydrate branch April 4, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant