Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[labs/ssr-client] Include node build output in npm package #3781

Merged
merged 2 commits into from Apr 3, 2023

Conversation

augustjk
Copy link
Member

@augustjk augustjk commented Apr 3, 2023

Fixes #3780

@changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2023

🦋 Changeset detected

Latest commit: d98610f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit-labs/ssr-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -2% - +7% (-0.47ms - +1.41ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 96.12ms - 100.20ms
  • lit-html-kitchen-sink: unsure 🔍 -8% - +5% (-3.58ms - +2.08ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -6% - +6% (-0.79ms - +0.80ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +7% (-2.00ms - +4.92ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -3% - +3% (-1.76ms - +1.83ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 1019.37ms - 1039.44ms
  • lit-html-kitchen-sink: unsure 🔍 -4% - +2% (-4.67ms - +2.06ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +3% (-7.94ms - +10.99ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +6% (-4.35ms - +8.88ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +1% (-19.72ms - +8.64ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 985.01ms - 1005.00ms
  • reactive-element-list: unsure 🔍 -1% - +2% (-11.40ms - +16.50ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
96.12ms - 100.20ms-

update

VersionAvg timevs
1019.37ms - 1039.44ms-

update-reflect

VersionAvg timevs
985.01ms - 1005.00ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
41.41ms - 45.45ms-unsure 🔍
-8% - +5%
-3.58ms - +2.08ms
unsure 🔍
-3% - +9%
-1.22ms - +3.73ms
tip-of-tree
tip-of-tree
42.20ms - 46.15msunsure 🔍
-5% - +8%
-2.08ms - +3.58ms
-unsure 🔍
-1% - +11%
-0.43ms - +4.44ms
previous-release
previous-release
40.74ms - 43.60msunsure 🔍
-8% - +3%
-3.73ms - +1.22ms
unsure 🔍
-10% - +1%
-4.44ms - +0.43ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
103.18ms - 108.56ms-unsure 🔍
-4% - +2%
-4.67ms - +2.06ms
unsure 🔍
-5% - +3%
-5.17ms - +2.76ms
tip-of-tree
tip-of-tree
105.16ms - 109.20msunsure 🔍
-2% - +4%
-2.06ms - +4.67ms
-unsure 🔍
-3% - +3%
-3.45ms - +3.65ms
previous-release
previous-release
104.16ms - 109.99msunsure 🔍
-3% - +5%
-2.76ms - +5.17ms
unsure 🔍
-3% - +3%
-3.65ms - +3.45ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
19.45ms - 21.00ms-unsure 🔍
-2% - +7%
-0.47ms - +1.41ms
unsure 🔍
-4% - +8%
-0.73ms - +1.48ms
tip-of-tree
tip-of-tree
19.22ms - 20.29msunsure 🔍
-7% - +2%
-1.41ms - +0.47ms
-unsure 🔍
-5% - +4%
-1.05ms - +0.86ms
previous-release
previous-release
19.06ms - 20.64msunsure 🔍
-7% - +4%
-1.48ms - +0.73ms
unsure 🔍
-4% - +5%
-0.86ms - +1.05ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
13.18ms - 14.26ms-unsure 🔍
-6% - +6%
-0.79ms - +0.80ms
unsure 🔍
-6% - +7%
-0.88ms - +0.91ms
tip-of-tree
tip-of-tree
13.13ms - 14.30msunsure 🔍
-6% - +6%
-0.80ms - +0.79ms
-unsure 🔍
-7% - +7%
-0.91ms - +0.94ms
previous-release
previous-release
12.99ms - 14.42msunsure 🔍
-7% - +6%
-0.91ms - +0.88ms
unsure 🔍
-7% - +7%
-0.94ms - +0.91ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
318.01ms - 332.53ms-unsure 🔍
-2% - +3%
-7.94ms - +10.99ms
unsure 🔍
-3% - +4%
-8.62ms - +11.61ms
tip-of-tree
tip-of-tree
317.67ms - 329.82msunsure 🔍
-3% - +2%
-10.99ms - +7.94ms
-unsure 🔍
-3% - +3%
-9.34ms - +9.28ms
previous-release
previous-release
316.72ms - 330.83msunsure 🔍
-4% - +3%
-11.61ms - +8.62ms
unsure 🔍
-3% - +3%
-9.28ms - +9.34ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
67.90ms - 73.37ms-unsure 🔍
-3% - +7%
-2.00ms - +4.92ms
unsure 🔍
-6% - +6%
-4.11ms - +4.30ms
tip-of-tree
tip-of-tree
67.06ms - 71.29msunsure 🔍
-7% - +3%
-4.92ms - +2.00ms
-unsure 🔍
-7% - +3%
-5.20ms - +2.46ms
previous-release
previous-release
67.35ms - 73.74msunsure 🔍
-6% - +6%
-4.30ms - +4.11ms
unsure 🔍
-4% - +8%
-2.46ms - +5.20ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
140.83ms - 150.97ms-unsure 🔍
-3% - +6%
-4.35ms - +8.88ms
unsure 🔍
-4% - +5%
-5.95ms - +6.88ms
tip-of-tree
tip-of-tree
139.39ms - 147.89msunsure 🔍
-6% - +3%
-8.88ms - +4.35ms
-unsure 🔍
-5% - +3%
-7.59ms - +3.99ms
previous-release
previous-release
141.51ms - 149.37msunsure 🔍
-5% - +4%
-6.88ms - +5.95ms
unsure 🔍
-3% - +5%
-3.99ms - +7.59ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
66.31ms - 68.87ms-unsure 🔍
-3% - +3%
-1.76ms - +1.83ms
unsure 🔍
-2% - +3%
-1.48ms - +2.31ms
tip-of-tree
tip-of-tree
66.30ms - 68.81msunsure 🔍
-3% - +3%
-1.83ms - +1.76ms
-unsure 🔍
-2% - +3%
-1.50ms - +2.26ms
previous-release
previous-release
65.78ms - 68.57msunsure 🔍
-3% - +2%
-2.31ms - +1.48ms
unsure 🔍
-3% - +2%
-2.26ms - +1.50ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1029.92ms - 1050.85ms-unsure 🔍
-2% - +1%
-19.72ms - +8.64ms
unsure 🔍
-1% - +2%
-5.95ms - +20.96ms
tip-of-tree
tip-of-tree
1036.35ms - 1055.50msunsure 🔍
-1% - +2%
-8.64ms - +19.72ms
-slower ❌
0% - 3%
0.26ms - 25.82ms
previous-release
previous-release
1024.42ms - 1041.35msunsure 🔍
-2% - +1%
-20.96ms - +5.95ms
faster ✔
0% - 2%
0.26ms - 25.82ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
1037.03ms - 1054.37ms-unsure 🔍
-1% - +2%
-11.40ms - +16.50ms
unsure 🔍
-1% - +1%
-11.16ms - +13.38ms
tip-of-tree
tip-of-tree
1032.23ms - 1054.07msunsure 🔍
-2% - +1%
-16.50ms - +11.40ms
-unsure 🔍
-1% - +1%
-15.39ms - +12.51ms
previous-release
previous-release
1035.91ms - 1053.27msunsure 🔍
-1% - +1%
-13.38ms - +11.16ms
unsure 🔍
-1% - +1%
-12.51ms - +15.39ms
-

tachometer-reporter-action v2 for Benchmarks

@augustjk augustjk merged commit 41b18f3 into main Apr 3, 2023
6 of 7 checks passed
@augustjk augustjk deleted the ssr-client-node branch April 3, 2023 23:29
@lit-robot lit-robot mentioned this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[labs/ssr-client] Node build artifact not included in npm package
2 participants