Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow numbers to be used as values in styleMap() #3788

Merged
merged 3 commits into from Apr 5, 2023
Merged

Conversation

justinfagnani
Copy link
Collaborator

Fixes #3787

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2023

🦋 Changeset detected

Latest commit: e33a2b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
lit-html Patch
lit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -2% - +5% (-0.35ms - +0.94ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 89.09ms - 92.71ms
  • lit-html-kitchen-sink: unsure 🔍 -7% - +5% (-2.69ms - +1.99ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +13% (-0.14ms - +1.68ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +6% (-0.50ms - +3.93ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -4% - +3% (-2.37ms - +1.69ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 928.45ms - 940.68ms
  • lit-html-kitchen-sink: unsure 🔍 -6% - +3% (-5.64ms - +3.03ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -1% - +4% (-2.60ms - +14.64ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -2% - +3% (-2.99ms - +3.63ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +0% (-14.76ms - +3.07ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 894.37ms - 907.72ms
  • reactive-element-list: unsure 🔍 -2% - +0% (-17.62ms - +1.14ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
89.09ms - 92.71ms-

update

VersionAvg timevs
928.45ms - 940.68ms-

update-reflect

VersionAvg timevs
894.37ms - 907.72ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
36.43ms - 39.94ms-unsure 🔍
-7% - +5%
-2.69ms - +1.99ms
unsure 🔍
-6% - +6%
-2.49ms - +2.18ms
tip-of-tree
tip-of-tree
36.99ms - 40.08msunsure 🔍
-5% - +7%
-1.99ms - +2.69ms
-unsure 🔍
-5% - +6%
-1.99ms - +2.38ms
previous-release
previous-release
36.79ms - 39.88msunsure 🔍
-6% - +7%
-2.18ms - +2.49ms
unsure 🔍
-6% - +5%
-2.38ms - +1.99ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
91.21ms - 95.80ms-unsure 🔍
-6% - +3%
-5.64ms - +3.03ms
unsure 🔍
-5% - +2%
-4.51ms - +1.73ms
tip-of-tree
tip-of-tree
91.14ms - 98.49msunsure 🔍
-3% - +6%
-3.03ms - +5.64ms
-unsure 🔍
-5% - +4%
-4.32ms - +4.16ms
previous-release
previous-release
92.78ms - 97.00msunsure 🔍
-2% - +5%
-1.73ms - +4.51ms
unsure 🔍
-4% - +5%
-4.16ms - +4.32ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
19.30ms - 20.32ms-unsure 🔍
-2% - +5%
-0.35ms - +0.94ms
unsure 🔍
-4% - +4%
-0.75ms - +0.71ms
tip-of-tree
tip-of-tree
19.12ms - 19.90msunsure 🔍
-5% - +2%
-0.94ms - +0.35ms
-unsure 🔍
-5% - +2%
-0.97ms - +0.34ms
previous-release
previous-release
19.30ms - 20.36msunsure 🔍
-4% - +4%
-0.71ms - +0.75ms
unsure 🔍
-2% - +5%
-0.34ms - +0.97ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
13.40ms - 14.64ms-unsure 🔍
-1% - +13%
-0.14ms - +1.68ms
unsure 🔍
-1% - +14%
-0.10ms - +1.77ms
tip-of-tree
tip-of-tree
12.58ms - 13.92msunsure 🔍
-12% - +1%
-1.68ms - +0.14ms
-unsure 🔍
-7% - +8%
-0.90ms - +1.03ms
previous-release
previous-release
12.49ms - 13.89msunsure 🔍
-12% - +1%
-1.77ms - +0.10ms
unsure 🔍
-8% - +7%
-1.03ms - +0.90ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
342.94ms - 356.01ms-unsure 🔍
-1% - +4%
-2.60ms - +14.64ms
slower ❌
0% - 5%
1.06ms - 16.56ms
tip-of-tree
tip-of-tree
337.83ms - 349.07msunsure 🔍
-4% - +1%
-14.64ms - +2.60ms
-unsure 🔍
-1% - +3%
-4.21ms - +9.77ms
previous-release
previous-release
336.51ms - 344.83msfaster ✔
0% - 5%
1.06ms - 16.56ms
unsure 🔍
-3% - +1%
-9.77ms - +4.21ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
65.69ms - 69.34ms-unsure 🔍
-1% - +6%
-0.50ms - +3.93ms
unsure 🔍
-1% - +6%
-0.72ms - +3.70ms
tip-of-tree
tip-of-tree
64.55ms - 67.06msunsure 🔍
-6% - +1%
-3.93ms - +0.50ms
-unsure 🔍
-3% - +2%
-1.99ms - +1.54ms
previous-release
previous-release
64.78ms - 67.27msunsure 🔍
-5% - +1%
-3.70ms - +0.72ms
unsure 🔍
-2% - +3%
-1.54ms - +1.99ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
140.19ms - 144.77ms-unsure 🔍
-2% - +3%
-2.99ms - +3.63ms
unsure 🔍
-2% - +2%
-2.55ms - +3.29ms
tip-of-tree
tip-of-tree
139.77ms - 144.55msunsure 🔍
-3% - +2%
-3.63ms - +2.99ms
-unsure 🔍
-2% - +2%
-2.95ms - +3.04ms
previous-release
previous-release
140.30ms - 143.92msunsure 🔍
-2% - +2%
-3.29ms - +2.55ms
unsure 🔍
-2% - +2%
-3.04ms - +2.95ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
58.20ms - 61.22ms-unsure 🔍
-4% - +3%
-2.37ms - +1.69ms
unsure 🔍
-2% - +5%
-1.21ms - +3.05ms
tip-of-tree
tip-of-tree
58.70ms - 61.41msunsure 🔍
-3% - +4%
-1.69ms - +2.37ms
-unsure 🔍
-1% - +6%
-0.76ms - +3.29ms
previous-release
previous-release
57.29ms - 60.30msunsure 🔍
-5% - +2%
-3.05ms - +1.21ms
unsure 🔍
-5% - +1%
-3.29ms - +0.76ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
954.19ms - 966.74ms-unsure 🔍
-2% - +0%
-14.76ms - +3.07ms
unsure 🔍
-1% - +1%
-12.75ms - +6.02ms
tip-of-tree
tip-of-tree
959.97ms - 972.64msunsure 🔍
-0% - +2%
-3.07ms - +14.76ms
-unsure 🔍
-1% - +1%
-6.95ms - +11.90ms
previous-release
previous-release
956.85ms - 970.81msunsure 🔍
-1% - +1%
-6.02ms - +12.75ms
unsure 🔍
-1% - +1%
-11.90ms - +6.95ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
937.52ms - 952.51ms-unsure 🔍
-2% - +0%
-17.62ms - +1.14ms
unsure 🔍
-2% - +1%
-14.71ms - +6.53ms
tip-of-tree
tip-of-tree
947.61ms - 958.90msunsure 🔍
-0% - +2%
-1.14ms - +17.62ms
-unsure 🔍
-1% - +1%
-5.26ms - +13.56ms
previous-release
previous-release
941.58ms - 956.63msunsure 🔍
-1% - +2%
-6.53ms - +14.71ms
unsure 🔍
-1% - +1%
-13.56ms - +5.26ms
-

tachometer-reporter-action v2 for Benchmarks

Co-authored-by: Augustine Kim <augustinekim@google.com>
- Adjust changeset
- Add z-index assertions to tests
@augustjk augustjk merged commit 88fe039 into main Apr 5, 2023
6 of 7 checks passed
@augustjk augustjk deleted the style-map-numbers branch April 5, 2023 20:50
@lit-robot lit-robot mentioned this pull request Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lit-html] styleMap breaks if value is a number
2 participants