Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Skip styleMap priority test in IE11 #3789

Merged
merged 2 commits into from Apr 5, 2023
Merged

Conversation

augustjk
Copy link
Member

@augustjk augustjk commented Apr 5, 2023

The test introduced in #3768 is consistently failing in IE11 sauce pipeline. IE does not seem to properly handle the priority argument.

@changeset-bot
Copy link

changeset-bot bot commented Apr 5, 2023

🦋 Changeset detected

Latest commit: 100553e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -11% - +3% (-2.26ms - +0.58ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 92.11ms - 98.10ms
  • lit-html-kitchen-sink: unsure 🔍 -5% - +6% (-1.74ms - +2.11ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +9% (-0.27ms - +1.23ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +2% (-2.03ms - +1.60ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -4% - +3% (-2.28ms - +2.08ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 923.89ms - 938.75ms
  • lit-html-kitchen-sink: unsure 🔍 -6% - +3% (-6.34ms - +2.81ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -2% - +3% (-8.60ms - +10.64ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -1% - +2% (-1.39ms - +2.41ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -0% - +1% (-3.72ms - +10.50ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 882.54ms - 891.31ms
  • reactive-element-list: unsure 🔍 -1% - +0% (-9.02ms - +2.01ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
92.11ms - 98.10ms-

update

VersionAvg timevs
923.89ms - 938.75ms-

update-reflect

VersionAvg timevs
882.54ms - 891.31ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
36.61ms - 39.09ms-unsure 🔍
-5% - +6%
-1.74ms - +2.11ms
unsure 🔍
-7% - +2%
-2.92ms - +0.74ms
tip-of-tree
tip-of-tree
36.18ms - 39.14msunsure 🔍
-6% - +5%
-2.11ms - +1.74ms
-unsure 🔍
-8% - +2%
-3.28ms - +0.72ms
previous-release
previous-release
37.60ms - 40.28msunsure 🔍
-2% - +8%
-0.74ms - +2.92ms
unsure 🔍
-2% - +9%
-0.72ms - +3.28ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
93.63ms - 98.47ms-unsure 🔍
-6% - +3%
-6.34ms - +2.81ms
unsure 🔍
-5% - +2%
-4.97ms - +1.58ms
tip-of-tree
tip-of-tree
93.93ms - 101.70msunsure 🔍
-3% - +7%
-2.81ms - +6.34ms
-unsure 🔍
-4% - +5%
-4.39ms - +4.54ms
previous-release
previous-release
95.54ms - 99.95msunsure 🔍
-2% - +5%
-1.58ms - +4.97ms
unsure 🔍
-5% - +4%
-4.54ms - +4.39ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
19.44ms - 20.58ms-unsure 🔍
-11% - +3%
-2.26ms - +0.58ms
unsure 🔍
-5% - +3%
-1.09ms - +0.63ms
tip-of-tree
tip-of-tree
19.55ms - 22.16msunsure 🔍
-3% - +11%
-0.58ms - +2.26ms
-unsure 🔍
-4% - +10%
-0.84ms - +2.07ms
previous-release
previous-release
19.59ms - 20.88msunsure 🔍
-3% - +5%
-0.63ms - +1.09ms
unsure 🔍
-10% - +4%
-2.07ms - +0.84ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
13.07ms - 14.09ms-unsure 🔍
-2% - +9%
-0.27ms - +1.23ms
unsure 🔍
-3% - +9%
-0.39ms - +1.15ms
tip-of-tree
tip-of-tree
12.55ms - 13.65msunsure 🔍
-9% - +2%
-1.23ms - +0.27ms
-unsure 🔍
-7% - +5%
-0.90ms - +0.70ms
previous-release
previous-release
12.62ms - 13.78msunsure 🔍
-8% - +3%
-1.15ms - +0.39ms
unsure 🔍
-5% - +7%
-0.70ms - +0.90ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
348.29ms - 361.73ms-unsure 🔍
-2% - +3%
-8.60ms - +10.64ms
unsure 🔍
-3% - +2%
-11.06ms - +7.50ms
tip-of-tree
tip-of-tree
347.10ms - 360.88msunsure 🔍
-3% - +2%
-10.64ms - +8.60ms
-unsure 🔍
-3% - +2%
-12.21ms - +6.61ms
previous-release
previous-release
350.39ms - 363.19msunsure 🔍
-2% - +3%
-7.50ms - +11.06ms
unsure 🔍
-2% - +3%
-6.61ms - +12.21ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
64.78ms - 67.54ms-unsure 🔍
-3% - +2%
-2.03ms - +1.60ms
unsure 🔍
-4% - +1%
-2.73ms - +0.91ms
tip-of-tree
tip-of-tree
65.20ms - 67.55msunsure 🔍
-2% - +3%
-1.60ms - +2.03ms
-unsure 🔍
-4% - +1%
-2.37ms - +0.98ms
previous-release
previous-release
65.88ms - 68.26msunsure 🔍
-1% - +4%
-0.91ms - +2.73ms
unsure 🔍
-1% - +4%
-0.98ms - +2.37ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
140.16ms - 143.48ms-unsure 🔍
-1% - +2%
-1.39ms - +2.41ms
unsure 🔍
-2% - +2%
-2.14ms - +2.61ms
tip-of-tree
tip-of-tree
140.38ms - 142.24msunsure 🔍
-2% - +1%
-2.41ms - +1.39ms
-unsure 🔍
-2% - +1%
-2.21ms - +1.66ms
previous-release
previous-release
139.88ms - 143.29msunsure 🔍
-2% - +2%
-2.61ms - +2.14ms
unsure 🔍
-1% - +2%
-1.66ms - +2.21ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
59.55ms - 62.44ms-unsure 🔍
-4% - +3%
-2.28ms - +2.08ms
unsure 🔍
-4% - +2%
-2.35ms - +1.54ms
tip-of-tree
tip-of-tree
59.46ms - 62.72msunsure 🔍
-3% - +4%
-2.08ms - +2.28ms
-unsure 🔍
-4% - +3%
-2.39ms - +1.78ms
previous-release
previous-release
60.10ms - 62.70msunsure 🔍
-3% - +4%
-1.54ms - +2.35ms
unsure 🔍
-3% - +4%
-1.78ms - +2.39ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
940.71ms - 952.11ms-unsure 🔍
-0% - +1%
-3.72ms - +10.50ms
unsure 🔍
-1% - +1%
-7.37ms - +7.47ms
tip-of-tree
tip-of-tree
938.77ms - 947.27msunsure 🔍
-1% - +0%
-10.50ms - +3.72ms
-unsure 🔍
-1% - +0%
-9.71ms - +3.03ms
previous-release
previous-release
941.61ms - 951.11msunsure 🔍
-1% - +1%
-7.47ms - +7.37ms
unsure 🔍
-0% - +1%
-3.03ms - +9.71ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
926.26ms - 933.29ms-unsure 🔍
-1% - +0%
-9.02ms - +2.01ms
faster ✔
0% - 2%
1.72ms - 14.25ms
tip-of-tree
tip-of-tree
929.02ms - 937.53msunsure 🔍
-0% - +1%
-2.01ms - +9.02ms
-unsure 🔍
-1% - +0%
-11.19ms - +2.22ms
previous-release
previous-release
932.57ms - 942.94msslower ❌
0% - 2%
1.72ms - 14.25ms
unsure 🔍
-0% - +1%
-2.22ms - +11.19ms
-

tachometer-reporter-action v2 for Benchmarks

@augustjk augustjk merged commit ab4e9c9 into main Apr 5, 2023
7 checks passed
@augustjk augustjk deleted the skip-style-test-ie11 branch April 5, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants