Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #3959

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Version Packages #3959

merged 1 commit into from
Jun 16, 2023

Conversation

lit-robot
Copy link
Member

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@lit-labs/context@0.3.3

Patch Changes

  • #3956 d1cc410e - Fix a memory leak when a context consumer sets subscribe: true.

@lit-labs/ssr@3.1.4

Patch Changes

  • #3942 ed42d5f0 - Fix adding node marker for hydration for nested custom elements without attributes. This ensures nested custom elements have their defer-hydration attribute removed when parent is hydrated even without any attributes or bindings.

@lit-labs/task@2.1.2

Patch Changes

  • #3953 2407c808 - Fix taskComplete not rejecting if after an error state

  • #3947 0480e006 - Task will not throw errors unless user requests taskComplete

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2023

📊 Tachometer Benchmark Results

Summary

nop-update

  • lit-html-kitchen-sink: unsure 🔍 -13% - +5% (-3.09ms - +1.30ms)
    this-change vs tip-of-tree

render

  • lit-element-list: 67.69ms - 72.29ms
  • lit-html-kitchen-sink: unsure 🔍 -9% - +7% (-2.82ms - +2.05ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -4% - +3% (-0.37ms - +0.26ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -4% - +1% (-2.05ms - +0.55ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -2% - +2% (-0.70ms - +0.81ms)
    this-change vs tip-of-tree

update

  • lit-element-list: 756.11ms - 769.49ms
  • lit-html-kitchen-sink: unsure 🔍 -4% - +5% (-3.06ms - +4.21ms)
    this-change vs tip-of-tree
  • lit-html-repeat: unsure 🔍 -4% - +3% (-11.37ms - +8.89ms)
    this-change vs tip-of-tree
  • lit-html-template-heavy: unsure 🔍 -3% - +1% (-3.50ms - +0.64ms)
    this-change vs tip-of-tree
  • reactive-element-list: unsure 🔍 -1% - +1% (-5.05ms - +11.30ms)
    this-change vs tip-of-tree

update-reflect

  • lit-element-list: 716.22ms - 726.05ms
  • reactive-element-list: unsure 🔍 -1% - +1% (-5.84ms - +6.61ms)
    this-change vs tip-of-tree

Results

lit-element-list

render

VersionAvg timevs
67.69ms - 72.29ms-

update

VersionAvg timevs
756.11ms - 769.49ms-

update-reflect

VersionAvg timevs
716.22ms - 726.05ms-
lit-html-kitchen-sink

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
27.77ms - 31.30ms-unsure 🔍
-9% - +7%
-2.82ms - +2.05ms
unsure 🔍
-11% - +7%
-3.43ms - +2.09ms
tip-of-tree
tip-of-tree
28.24ms - 31.60msunsure 🔍
-7% - +10%
-2.05ms - +2.82ms
-unsure 🔍
-10% - +8%
-2.99ms - +2.43ms
previous-release
previous-release
28.08ms - 32.32msunsure 🔍
-7% - +12%
-2.09ms - +3.43ms
unsure 🔍
-8% - +10%
-2.43ms - +2.99ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
74.53ms - 80.13ms-unsure 🔍
-4% - +5%
-3.06ms - +4.21ms
unsure 🔍
-5% - +6%
-3.91ms - +4.25ms
tip-of-tree
tip-of-tree
74.44ms - 79.07msunsure 🔍
-5% - +4%
-4.21ms - +3.06ms
-unsure 🔍
-5% - +4%
-4.17ms - +3.36ms
previous-release
previous-release
74.19ms - 80.13msunsure 🔍
-5% - +5%
-4.25ms - +3.91ms
unsure 🔍
-4% - +5%
-3.36ms - +4.17ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
20.62ms - 23.54ms-unsure 🔍
-13% - +5%
-3.09ms - +1.30ms
unsure 🔍
-7% - +11%
-1.53ms - +2.33ms
tip-of-tree
tip-of-tree
21.34ms - 24.61msunsure 🔍
-6% - +14%
-1.30ms - +3.09ms
-unsure 🔍
-4% - +16%
-0.76ms - +3.36ms
previous-release
previous-release
20.42ms - 22.93msunsure 🔍
-10% - +7%
-2.33ms - +1.53ms
unsure 🔍
-14% - +3%
-3.36ms - +0.76ms
-
lit-html-repeat

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
9.17ms - 9.63ms-unsure 🔍
-4% - +3%
-0.37ms - +0.26ms
unsure 🔍
-5% - +2%
-0.47ms - +0.20ms
tip-of-tree
tip-of-tree
9.25ms - 9.67msunsure 🔍
-3% - +4%
-0.26ms - +0.37ms
-unsure 🔍
-4% - +3%
-0.39ms - +0.24ms
previous-release
previous-release
9.29ms - 9.77msunsure 🔍
-2% - +5%
-0.20ms - +0.47ms
unsure 🔍
-3% - +4%
-0.24ms - +0.39ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
275.24ms - 288.27ms-unsure 🔍
-4% - +3%
-11.37ms - +8.89ms
unsure 🔍
-2% - +4%
-5.89ms - +10.98ms
tip-of-tree
tip-of-tree
275.24ms - 290.75msunsure 🔍
-3% - +4%
-8.89ms - +11.37ms
-unsure 🔍
-2% - +5%
-5.64ms - +13.21ms
previous-release
previous-release
273.85ms - 284.57msunsure 🔍
-4% - +2%
-10.98ms - +5.89ms
unsure 🔍
-5% - +2%
-13.21ms - +5.64ms
-
lit-html-template-heavy

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
48.52ms - 50.04ms-unsure 🔍
-4% - +1%
-2.05ms - +0.55ms
unsure 🔍
-4% - +1%
-1.86ms - +0.49ms
tip-of-tree
tip-of-tree
48.97ms - 51.09msunsure 🔍
-1% - +4%
-0.55ms - +2.05ms
-unsure 🔍
-3% - +3%
-1.32ms - +1.45ms
previous-release
previous-release
49.07ms - 50.87msunsure 🔍
-1% - +4%
-0.49ms - +1.86ms
unsure 🔍
-3% - +3%
-1.45ms - +1.32ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
106.07ms - 108.17ms-unsure 🔍
-3% - +1%
-3.50ms - +0.64ms
unsure 🔍
-2% - +1%
-2.10ms - +1.23ms
tip-of-tree
tip-of-tree
106.77ms - 110.34msunsure 🔍
-1% - +3%
-0.64ms - +3.50ms
-unsure 🔍
-1% - +3%
-1.21ms - +3.19ms
previous-release
previous-release
106.27ms - 108.85msunsure 🔍
-1% - +2%
-1.23ms - +2.10ms
unsure 🔍
-3% - +1%
-3.19ms - +1.21ms
-
reactive-element-list

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
43.88ms - 44.88ms-unsure 🔍
-2% - +2%
-0.70ms - +0.81ms
unsure 🔍
-2% - +1%
-0.92ms - +0.58ms
tip-of-tree
tip-of-tree
43.76ms - 44.89msunsure 🔍
-2% - +2%
-0.81ms - +0.70ms
-unsure 🔍
-2% - +1%
-1.02ms - +0.57ms
previous-release
previous-release
44.00ms - 45.10msunsure 🔍
-1% - +2%
-0.58ms - +0.92ms
unsure 🔍
-1% - +2%
-0.57ms - +1.02ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
781.06ms - 792.48ms-unsure 🔍
-1% - +1%
-5.05ms - +11.30ms
unsure 🔍
-1% - +1%
-5.70ms - +10.97ms
tip-of-tree
tip-of-tree
777.80ms - 789.49msunsure 🔍
-1% - +1%
-11.30ms - +5.05ms
-unsure 🔍
-1% - +1%
-8.92ms - +7.94ms
previous-release
previous-release
778.06ms - 790.21msunsure 🔍
-1% - +1%
-10.97ms - +5.70ms
unsure 🔍
-1% - +1%
-7.94ms - +8.92ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
760.18ms - 768.92ms-unsure 🔍
-1% - +1%
-5.84ms - +6.61ms
unsure 🔍
-1% - +1%
-9.57ms - +3.93ms
tip-of-tree
tip-of-tree
759.72ms - 768.60msunsure 🔍
-1% - +1%
-6.61ms - +5.84ms
-unsure 🔍
-1% - +0%
-10.00ms - +3.58ms
previous-release
previous-release
762.23ms - 772.52msunsure 🔍
-1% - +1%
-3.93ms - +9.57ms
unsure 🔍
-0% - +1%
-3.58ms - +10.00ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for driving this @augustjk

@augustjk augustjk merged commit 5149081 into main Jun 16, 2023
8 checks passed
@augustjk augustjk deleted the changeset-release/main branch June 16, 2023 17:53
@justinfagnani justinfagnani mentioned this pull request Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants