[lit-html] Make RefOrCallback generic

[justinfagnani]

Make RefOrCallback generic like Ref<T>.

Fixes #3966

[changeset-bot]

🦋 Changeset detected

Latest commit: 52ea0a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
lit-html	Patch
lit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

📊 Tachometer Benchmark Results

Summary

nop-update

• lit-html-kitchen-sink: unsure 🔍 -8% - +7% (-1.79ms - +1.51ms)
  ^{this-change vs tip-of-tree}

render

• lit-element-list: 68.87ms - 72.26ms
• lit-html-kitchen-sink: unsure 🔍 -7% - +9% (-2.08ms - +2.64ms)
  ^{this-change vs tip-of-tree}
• lit-html-repeat: unsure 🔍 -3% - +4% (-0.26ms - +0.34ms)
  ^{this-change vs tip-of-tree}
• lit-html-template-heavy: unsure 🔍 -3% - +2% (-1.41ms - +1.28ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -3% - +1% (-1.16ms - +0.51ms)
  ^{this-change vs tip-of-tree}

update

• lit-element-list: 782.15ms - 793.11ms
• lit-html-kitchen-sink: unsure 🔍 -4% - +7% (-3.15ms - +5.42ms)
  ^{this-change vs tip-of-tree}
• lit-html-repeat: unsure 🔍 -4% - +3% (-11.06ms - +7.18ms)
  ^{this-change vs tip-of-tree}
• lit-html-template-heavy: unsure 🔍 -1% - +2% (-1.50ms - +1.90ms)
  ^{this-change vs tip-of-tree}
• reactive-element-list: unsure 🔍 -0% - +2% (-2.35ms - +12.87ms)
  ^{this-change vs tip-of-tree}

update-reflect

• lit-element-list: 744.55ms - 752.74ms
• reactive-element-list: unsure 🔍 -1% - +1% (-4.50ms - +8.64ms)
  ^{this-change vs tip-of-tree}

Results

lit-element-list

• Browser: chrome-headless 114.0.5735.106
• Sample size: 50
• Built by: Benchmarks #4913

• Commit: 6b32af9

render

Version	Avg time	vs
	68.87ms - 72.26ms	-

update

Version	Avg time	vs
	782.15ms - 793.11ms	-

update-reflect

Version	Avg time	vs
	744.55ms - 752.74ms	-

lit-html-kitchen-sink

• Browser: chrome-headless 114.0.5735.106
• Sample size: 30
• Built by: Benchmarks #4913

• Commit: 6b32af9

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	29.58ms - 32.90ms	-	unsure 🔍 -7% - +9% -2.08ms - +2.64ms	unsure 🔍 -6% - +10% -1.70ms - +2.95ms
tip-of-tree tip-of-tree	29.29ms - 32.63ms	unsure 🔍 -8% - +7% -2.64ms - +2.08ms	-	unsure 🔍 -7% - +9% -1.99ms - +2.68ms
previous-release previous-release	28.99ms - 32.25ms	unsure 🔍 -9% - +5% -2.95ms - +1.70ms	unsure 🔍 -9% - +6% -2.68ms - +1.99ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	74.76ms - 81.30ms	-	unsure 🔍 -4% - +7% -3.15ms - +5.42ms	unsure 🔍 -8% - +3% -6.49ms - +2.09ms
tip-of-tree tip-of-tree	74.12ms - 79.67ms	unsure 🔍 -7% - +4% -5.42ms - +3.15ms	-	unsure 🔍 -9% - +1% -7.26ms - +0.60ms
previous-release previous-release	77.44ms - 83.01ms	unsure 🔍 -3% - +8% -2.09ms - +6.49ms	unsure 🔍 -1% - +10% -0.60ms - +7.26ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	20.43ms - 23.01ms	-	unsure 🔍 -8% - +7% -1.79ms - +1.51ms	unsure 🔍 -15% - +1% -3.71ms - +0.35ms
tip-of-tree tip-of-tree	20.83ms - 22.89ms	unsure 🔍 -7% - +8% -1.51ms - +1.79ms	-	unsure 🔍 -14% - +1% -3.41ms - +0.33ms
previous-release previous-release	21.83ms - 24.96ms	unsure 🔍 -2% - +17% -0.35ms - +3.71ms	unsure 🔍 -2% - +16% -0.33ms - +3.41ms	-

lit-html-repeat

• Browser: chrome-headless 114.0.5735.106
• Sample size: 30
• Built by: Benchmarks #4913

• Commit: 6b32af9

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	9.44ms - 9.84ms	-	unsure 🔍 -3% - +4% -0.26ms - +0.34ms	unsure 🔍 -3% - +3% -0.27ms - +0.29ms
tip-of-tree tip-of-tree	9.38ms - 9.82ms	unsure 🔍 -4% - +3% -0.34ms - +0.26ms	-	unsure 🔍 -3% - +3% -0.32ms - +0.26ms
previous-release previous-release	9.43ms - 9.83ms	unsure 🔍 -3% - +3% -0.29ms - +0.27ms	unsure 🔍 -3% - +3% -0.26ms - +0.32ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	277.11ms - 289.19ms	-	unsure 🔍 -4% - +3% -11.06ms - +7.18ms	unsure 🔍 -4% - +2% -11.48ms - +5.78ms
tip-of-tree tip-of-tree	278.25ms - 291.93ms	unsure 🔍 -3% - +4% -7.18ms - +11.06ms	-	unsure 🔍 -4% - +3% -10.11ms - +8.29ms
previous-release previous-release	279.84ms - 292.16ms	unsure 🔍 -2% - +4% -5.78ms - +11.48ms	unsure 🔍 -3% - +4% -8.29ms - +10.11ms	-

lit-html-template-heavy

• Browser: chrome-headless 114.0.5735.106
• Sample size: 50
• Built by: Benchmarks #4913

• Commit: 6b32af9

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	50.07ms - 52.06ms	-	unsure 🔍 -3% - +2% -1.41ms - +1.28ms	unsure 🔍 -4% - +3% -1.80ms - +1.37ms
tip-of-tree tip-of-tree	50.23ms - 52.03ms	unsure 🔍 -3% - +3% -1.28ms - +1.41ms	-	unsure 🔍 -3% - +3% -1.68ms - +1.38ms
previous-release previous-release	50.05ms - 52.51ms	unsure 🔍 -3% - +4% -1.37ms - +1.80ms	unsure 🔍 -3% - +3% -1.38ms - +1.68ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	110.19ms - 112.82ms	-	unsure 🔍 -1% - +2% -1.50ms - +1.90ms	unsure 🔍 -2% - +1% -2.42ms - +1.58ms
tip-of-tree tip-of-tree	110.23ms - 112.39ms	unsure 🔍 -2% - +1% -1.90ms - +1.50ms	-	unsure 🔍 -2% - +1% -2.47ms - +1.23ms
previous-release previous-release	110.42ms - 113.43ms	unsure 🔍 -1% - +2% -1.58ms - +2.42ms	unsure 🔍 -1% - +2% -1.23ms - +2.47ms	-

reactive-element-list

• Browser: chrome-headless 114.0.5735.106
• Sample size: 50
• Built by: Benchmarks #4913

• Commit: 6b32af9

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	44.18ms - 45.37ms	-	unsure 🔍 -3% - +1% -1.16ms - +0.51ms	unsure 🔍 -4% - -0% -1.71ms - +0.00ms
tip-of-tree tip-of-tree	44.52ms - 45.68ms	unsure 🔍 -1% - +3% -0.51ms - +1.16ms	-	unsure 🔍 -3% - +1% -1.37ms - +0.31ms
previous-release previous-release	45.02ms - 46.23ms	unsure 🔍 -0% - +4% -0.00ms - +1.71ms	unsure 🔍 -1% - +3% -0.31ms - +1.37ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	810.92ms - 820.70ms	-	unsure 🔍 -0% - +2% -2.35ms - +12.87ms	unsure 🔍 -1% - +1% -6.59ms - +8.80ms
tip-of-tree tip-of-tree	804.72ms - 816.38ms	unsure 🔍 -2% - +0% -12.87ms - +2.35ms	-	unsure 🔍 -2% - +1% -12.48ms - +4.17ms
previous-release previous-release	808.76ms - 820.64ms	unsure 🔍 -1% - +1% -8.80ms - +6.59ms	unsure 🔍 -1% - +2% -4.17ms - +12.48ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	788.91ms - 798.05ms	-	unsure 🔍 -1% - +1% -4.50ms - +8.64ms	unsure 🔍 -1% - +1% -6.78ms - +6.58ms
tip-of-tree tip-of-tree	786.69ms - 796.13ms	unsure 🔍 -1% - +1% -8.64ms - +4.50ms	-	unsure 🔍 -1% - +1% -8.96ms - +4.61ms
previous-release previous-release	788.71ms - 798.45ms	unsure 🔍 -1% - +1% -6.58ms - +6.78ms	unsure 🔍 -1% - +1% -4.61ms - +8.96ms	-

_{tachometer-reporter-action v2 for Benchmarks}