Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency versions for labs/ssr and related packages #4311

Merged
merged 2 commits into from Oct 23, 2023

Conversation

augustjk
Copy link
Member

@augustjk augustjk commented Oct 19, 2023

Last of the dependency version changes!

Affected packages:

  • '@lit-labs/eleventy-plugin-lit': patch
  • '@lit-labs/ssr': patch
  • '@lit-labs/ssr-client': patch

Minimum versions used:

Also,

  • '@lit-labs/ssr-react': patch

Moved lit package from dependency to dev dependency because it's not actually used for library code, only for testing.

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

🦋 Changeset detected

Latest commit: f30b4ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@lit-labs/eleventy-plugin-lit Patch
@lit-labs/ssr Patch
@lit-labs/ssr-client Patch
@lit-labs/ssr-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -9% - +7% (-1.78ms - +1.53ms)
    this-change vs tip-of-tree

render

  • this-change: 79.43ms - 83.40ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -7% - +5% (-2.43ms - +1.79ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +3% (-1.84ms - +1.51ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +3% (-1.45ms - +1.57ms)
    this-change vs tip-of-tree

update

  • this-change: 876.04ms - 892.56ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +6% (-1.78ms - +4.19ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-2.61ms - +3.34ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-9.61ms - +13.12ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 854.58ms - 868.97ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-8.18ms - +13.36ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
79.43ms - 83.40ms-

update

VersionAvg timevs
876.04ms - 892.56ms-

update-reflect

VersionAvg timevs
854.58ms - 868.97ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
30.53ms - 33.78ms-unsure 🔍
-7% - +5%
-2.43ms - +1.79ms
unsure 🔍
-8% - +6%
-2.56ms - +2.11ms
tip-of-tree
tip-of-tree
31.13ms - 33.82msunsure 🔍
-6% - +8%
-1.79ms - +2.43ms
-unsure 🔍
-6% - +7%
-2.05ms - +2.24ms
previous-release
previous-release
30.70ms - 34.06msunsure 🔍
-7% - +8%
-2.11ms - +2.56ms
unsure 🔍
-7% - +6%
-2.24ms - +2.05ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
73.35ms - 78.12ms-unsure 🔍
-2% - +6%
-1.78ms - +4.19ms
unsure 🔍
-7% - +3%
-5.21ms - +2.22ms
tip-of-tree
tip-of-tree
72.73ms - 76.32msunsure 🔍
-5% - +2%
-4.19ms - +1.78ms
-unsure 🔍
-8% - +1%
-6.06ms - +0.66ms
previous-release
previous-release
74.38ms - 80.07msunsure 🔍
-3% - +7%
-2.22ms - +5.21ms
unsure 🔍
-1% - +8%
-0.66ms - +6.06ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
18.88ms - 21.62ms-unsure 🔍
-9% - +7%
-1.78ms - +1.53ms
unsure 🔍
-11% - +6%
-2.40ms - +1.20ms
tip-of-tree
tip-of-tree
19.45ms - 21.30msunsure 🔍
-8% - +9%
-1.53ms - +1.78ms
-unsure 🔍
-9% - +5%
-1.97ms - +1.02ms
previous-release
previous-release
19.68ms - 22.02msunsure 🔍
-6% - +12%
-1.20ms - +2.40ms
unsure 🔍
-5% - +10%
-1.02ms - +1.97ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
58.15ms - 60.36ms-unsure 🔍
-3% - +3%
-1.84ms - +1.51ms
unsure 🔍
-2% - +3%
-1.19ms - +1.80ms
tip-of-tree
tip-of-tree
58.15ms - 60.68msunsure 🔍
-3% - +3%
-1.51ms - +1.84ms
-unsure 🔍
-2% - +4%
-1.15ms - +2.08ms
previous-release
previous-release
57.94ms - 59.96msunsure 🔍
-3% - +2%
-1.80ms - +1.19ms
unsure 🔍
-3% - +2%
-2.08ms - +1.15ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
134.09ms - 137.98ms-unsure 🔍
-2% - +2%
-2.61ms - +3.34ms
unsure 🔍
-2% - +2%
-2.71ms - +3.24ms
tip-of-tree
tip-of-tree
133.43ms - 137.92msunsure 🔍
-2% - +2%
-3.34ms - +2.61ms
-unsure 🔍
-2% - +2%
-3.27ms - +3.08ms
previous-release
previous-release
133.52ms - 138.02msunsure 🔍
-2% - +2%
-3.24ms - +2.71ms
unsure 🔍
-2% - +2%
-3.08ms - +3.27ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
54.38ms - 56.27ms-unsure 🔍
-3% - +3%
-1.45ms - +1.57ms
unsure 🔍
-1% - +4%
-0.65ms - +2.10ms
tip-of-tree
tip-of-tree
54.09ms - 56.44msunsure 🔍
-3% - +3%
-1.57ms - +1.45ms
-unsure 🔍
-2% - +4%
-0.87ms - +2.20ms
previous-release
previous-release
53.61ms - 55.59msunsure 🔍
-4% - +1%
-2.10ms - +0.65ms
unsure 🔍
-4% - +2%
-2.20ms - +0.87ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
915.26ms - 933.35ms-unsure 🔍
-1% - +1%
-9.61ms - +13.12ms
unsure 🔍
-2% - +1%
-17.43ms - +7.48ms
tip-of-tree
tip-of-tree
915.67ms - 929.44msunsure 🔍
-1% - +1%
-13.12ms - +9.61ms
-unsure 🔍
-2% - +0%
-17.72ms - +4.26ms
previous-release
previous-release
920.72ms - 937.85msunsure 🔍
-1% - +2%
-7.48ms - +17.43ms
unsure 🔍
-0% - +2%
-4.26ms - +17.72ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
904.83ms - 918.59ms-unsure 🔍
-1% - +1%
-8.18ms - +13.36ms
unsure 🔍
-0% - +2%
-4.24ms - +14.74ms
tip-of-tree
tip-of-tree
900.83ms - 917.40msunsure 🔍
-1% - +1%
-13.36ms - +8.18ms
-unsure 🔍
-1% - +1%
-7.90ms - +13.21ms
previous-release
previous-release
899.92ms - 913.00msunsure 🔍
-2% - +0%
-14.74ms - +4.24ms
unsure 🔍
-1% - +1%
-13.21ms - +7.90ms
-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link
Contributor

The size of lit-html.js and lit-core.min.js are as expected.

@augustjk augustjk enabled auto-merge (squash) October 23, 2023 17:40
@augustjk augustjk merged commit cabe72a into main Oct 23, 2023
7 of 8 checks passed
@augustjk augustjk deleted the ssr-package-versions branch October 23, 2023 17:58
This was referenced Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants