Make status of Task a readonly field

[jrencz]

Fix #4550

I'm not sure whether to makr it as BC break (major) or just as a patch - I see potential for this change to affect some implementations even if field was used against its intended purpose

[changeset-bot]

🦋 Changeset detected

Latest commit: 2c0860e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit/task	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

📊 Tachometer Benchmark Results

Summary

nop-update

• this-change, tip-of-tree, previous-release: faster ✔ 1% - 9% (0.08ms - 1.04ms)
  ^{this-change vs tip-of-tree}

render

• this-change: 44.09ms - 46.00ms
• this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +3% (-0.87ms - +0.50ms)
  ^{this-change vs tip-of-tree}
• this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +1% (-1.00ms - +0.25ms)
  ^{this-change vs tip-of-tree}
• this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +2% (-0.90ms - +0.55ms)
  ^{this-change vs tip-of-tree}

update

• this-change: 466.49ms - 471.02ms
• this-change, tip-of-tree, previous-release: unsure 🔍 -11% - +1% (-4.33ms - +0.36ms)
  ^{this-change vs tip-of-tree}
• this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +5% (-0.88ms - +3.20ms)
  ^{this-change vs tip-of-tree}
• this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-2.78ms - +7.76ms)
  ^{this-change vs tip-of-tree}

update-reflect

• this-change: 476.30ms - 480.81ms
• this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +0% (-6.29ms - +0.60ms)
  ^{this-change vs tip-of-tree}

Results

this-change

• Browser: chrome-headless 123.0.6312.58
• Sample size: 50
• Built by: Benchmarks #6171

• Commit: 2c0860e

render

Version	Avg time	vs
	44.09ms - 46.00ms	-

update

Version	Avg time	vs
	466.49ms - 471.02ms	-

update-reflect

Version	Avg time	vs
	476.30ms - 480.81ms	-

this-change, tip-of-tree, previous-release

• Browser: chrome-headless 123.0.6312.58
• Sample size: 30
• Built by: Benchmarks #6171

• Commit: 2c0860e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	17.61ms - 18.51ms	-	unsure 🔍 -5% - +3% -0.87ms - +0.50ms	unsure 🔍 -4% - +3% -0.80ms - +0.54ms
tip-of-tree tip-of-tree	17.73ms - 18.76ms	unsure 🔍 -3% - +5% -0.50ms - +0.87ms	-	unsure 🔍 -4% - +4% -0.65ms - +0.76ms
previous-release previous-release	17.70ms - 18.68ms	unsure 🔍 -3% - +4% -0.54ms - +0.80ms	unsure 🔍 -4% - +4% -0.76ms - +0.65ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	35.68ms - 39.01ms	-	unsure 🔍 -11% - +1% -4.33ms - +0.36ms	unsure 🔍 -9% - +3% -3.36ms - +1.32ms
tip-of-tree tip-of-tree	37.68ms - 40.98ms	unsure 🔍 -1% - +12% -0.36ms - +4.33ms	-	unsure 🔍 -4% - +9% -1.37ms - +3.29ms
previous-release previous-release	36.72ms - 40.02ms	unsure 🔍 -4% - +9% -1.32ms - +3.36ms	unsure 🔍 -8% - +3% -3.29ms - +1.37ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	10.16ms - 10.91ms	-	faster ✔ 1% - 9% 0.08ms - 1.04ms	unsure 🔍 -8% - +1% -0.87ms - +0.10ms
tip-of-tree tip-of-tree	10.79ms - 11.40ms	slower ❌ 1% - 10% 0.08ms - 1.04ms	-	unsure 🔍 -2% - +6% -0.26ms - +0.60ms
previous-release previous-release	10.61ms - 11.23ms	unsure 🔍 -1% - +8% -0.10ms - +0.87ms	unsure 🔍 -5% - +2% -0.60ms - +0.26ms	-

this-change, tip-of-tree, previous-release

• Browser: chrome-headless 123.0.6312.58
• Sample size: 50
• Built by: Benchmarks #6171

• Commit: 2c0860e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	32.33ms - 33.28ms	-	unsure 🔍 -3% - +1% -1.00ms - +0.25ms	faster ✔ 0% - 5% 0.02ms - 1.59ms
tip-of-tree tip-of-tree	32.77ms - 33.59ms	unsure 🔍 -1% - +3% -0.25ms - +1.00ms	-	unsure 🔍 -3% - +1% -1.18ms - +0.32ms
previous-release previous-release	32.98ms - 34.24ms	slower ❌ 0% - 5% 0.02ms - 1.59ms	unsure 🔍 -1% - +4% -0.32ms - +1.18ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	66.62ms - 70.61ms	-	unsure 🔍 -1% - +5% -0.88ms - +3.20ms	unsure 🔍 -3% - +4% -1.81ms - +2.89ms
tip-of-tree tip-of-tree	67.03ms - 67.87ms	unsure 🔍 -5% - +1% -3.20ms - +0.88ms	-	unsure 🔍 -3% - +1% -1.94ms - +0.69ms
previous-release previous-release	66.83ms - 69.32ms	unsure 🔍 -4% - +3% -2.89ms - +1.81ms	unsure 🔍 -1% - +3% -0.69ms - +1.94ms	-

this-change, tip-of-tree, previous-release

• Browser: chrome-headless 123.0.6312.58
• Sample size: 50
• Built by: Benchmarks #6171

• Commit: 2c0860e

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	30.02ms - 31.08ms	-	unsure 🔍 -3% - +2% -0.90ms - +0.55ms	unsure 🔍 -4% - +1% -1.36ms - +0.40ms
tip-of-tree tip-of-tree	30.24ms - 31.21ms	unsure 🔍 -2% - +3% -0.55ms - +0.90ms	-	unsure 🔍 -4% - +2% -1.15ms - +0.55ms
previous-release previous-release	30.33ms - 31.72ms	unsure 🔍 -1% - +4% -0.40ms - +1.36ms	unsure 🔍 -2% - +4% -0.55ms - +1.15ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	473.58ms - 482.76ms	-	unsure 🔍 -1% - +2% -2.78ms - +7.76ms	unsure 🔍 -1% - +2% -2.90ms - +7.30ms
tip-of-tree tip-of-tree	473.09ms - 478.27ms	unsure 🔍 -2% - +1% -7.76ms - +2.78ms	-	unsure 🔍 -1% - +1% -3.71ms - +3.12ms
previous-release previous-release	473.75ms - 478.19ms	unsure 🔍 -2% - +1% -7.30ms - +2.90ms	unsure 🔍 -1% - +1% -3.12ms - +3.71ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	512.21ms - 517.19ms	-	unsure 🔍 -1% - +0% -6.29ms - +0.60ms	unsure 🔍 -1% - +1% -5.00ms - +3.06ms
tip-of-tree tip-of-tree	515.16ms - 519.93ms	unsure 🔍 -0% - +1% -0.60ms - +6.29ms	-	unsure 🔍 -0% - +1% -2.09ms - +5.84ms
previous-release previous-release	512.50ms - 518.84ms	unsure 🔍 -1% - +1% -3.06ms - +5.00ms	unsure 🔍 -1% - +0% -5.84ms - +2.09ms	-

_{tachometer-reporter-action v2 for Benchmarks}

[justinfagnani]

This seems good to me. I think that we can consider status being writable as somewhat of a bug and this could be a patch or minor release.

We'll need the changeset file. Run npx changeset

[github-actions]

The size of lit-html.js and lit-core.min.js are as expected.

[justinfagnani]

ping @jrencz - can you add a changeset file?

[jrencz]

It's there: .changeset/smart-pianos-kick.md

Or is there something else I need to do?