Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[labs/ssr-dom-shim] Patch localName and tagName with customElements.define call #4553

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kyubisation
Copy link

This change extends the CustomElementRegistryShim to patch localName and tagName into the web component, when calling define.
This allows instances to call this.localName and this.tagName accordingly.

Fixes #3375

…lements.define call

This change extends the CustomElementRegistryShim to patch localName and tagName into the web component, when calling define.
This allows instances to call `this.localName` and `this.tagName` accordingly.

Fixes lit#3375
Copy link

changeset-bot bot commented Feb 20, 2024

⚠️ No Changeset found

Latest commit: e1dffa7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

📊 Tachometer Benchmark Results

Summary

A summary of the benchmark results will show here once they finish.

Results

The full results of your benchmarks will show here once they finish.

tachometer-reporter-action v2 for Benchmarks

@kyubisation kyubisation changed the title fix(@lit-labs/ssr-dom-shim): patch localName and tagName with customElements.define call [labs/ssr-dom-shim] Patch localName and tagName with customElements.define call Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[labs/ssr] Add localName to DOM emulation for SSR
1 participant