Ignition fix build #4571
Closed
Ignition fix build #4571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use a webview panel instead of a text editor. Also fix a missing wireit dep, do a bit of cleanup elsewhere.
* Add a comlink connection between the extension and the webview.
* The webview now makes iframes and connects to them. * Fix endpoints to bail if transferrables are used. VSCode doesn't support them, and this will at least let us know. I expect this won't come up, and moderate term we should just use the UI server to coordinate this stuff, so that we can use ordinary browsers too. * Add missing entry to wireit config. * Delete dangling iframe.
* Reconnect to the webview when it becomes visible Also don't use explicit port numbers. * Move uiServer and workspace management into its own file. * Remove another explicit port
WeakRef is optional at both the value and type level
Convert the ignition UI to a Lit element
Add devlog patches that aren't yet merged into main.
* Just run the ignition tests in CI * Run in xvfb-run -a to ensure we have an X
The fun stuff: panels and stories frame auto-update on changes
Smartly focus element's source when selected
This works, except that we don't yet fully account for Lit binding content.
Fix interact mode
Add getTemplateNodeBySourceId
Note: this currently only works for the first element in a file, since we don't have the code yet to get the sourceId from a parse5 node.
Highlight elements in page when selected in template outline.
We compile in the project server now.
Add getTemplateNodeBySourceId tests
No longer need to build the test project on build
🦋 Changeset detectedLatest commit: 11be917 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The size of lit-html.js and lit-core.min.js are as expected. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+75
to
+97
| context.body = /* html */ ` | ||
| <!doctype html> | ||
| <html> | ||
| <head> | ||
| <script type='module' src='http://localhost:${uiServerPort}/frame-entrypoint.js'></script> | ||
| <style id="_defaultStyles"></style> | ||
| <style> | ||
| body, html { | ||
| margin: 0; | ||
| padding: 0; | ||
| width: 100%; | ||
| height: 100%; | ||
| } | ||
| * { | ||
| box-sizing: border-box; | ||
| } | ||
| </style> | ||
| </head> | ||
| <body> | ||
| <ignition-storyboard src=${storySrc}></ignition-storyboard> | ||
| </body> | ||
| </html> | ||
| `; |
Check failure
Code scanning / CodeQL
Reflected cross-site scripting High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.