Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmarks] Update chromedriver with fixed CDN url #4573

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

augustjk
Copy link
Member

@augustjk augustjk commented Mar 7, 2024

Our benchmarks workflow now tries to auto download matching version of chromedriver for the chrome available in the github action runner.

But recently the CDN urls for the chromedriver has changed giggio/node-chromedriver#448 causing pipeline failures.

We need the latest version of chromedriver that contains the fix giggio/node-chromedriver@6c14fa7 which will find and use the correct CDN url.

Copy link

changeset-bot bot commented Mar 7, 2024

🦋 Changeset detected

Latest commit: 01f0933

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 7, 2024

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +6% (-0.32ms - +0.67ms)
    this-change vs tip-of-tree

render

  • this-change: 45.27ms - 47.13ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +4% (-0.52ms - +0.70ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +4% (-0.52ms - +1.38ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-0.67ms - +0.40ms)
    this-change vs tip-of-tree

update

  • this-change: 472.65ms - 477.34ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +7% (-1.72ms - +2.83ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-0.50ms - +1.60ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +2% (-3.93ms - +7.46ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 480.76ms - 484.59ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -0% - +2% (-2.38ms - +7.82ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
45.27ms - 47.13ms-

update

VersionAvg timevs
472.65ms - 477.34ms-

update-reflect

VersionAvg timevs
480.76ms - 484.59ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
18.32ms - 19.18ms-unsure 🔍
-3% - +4%
-0.52ms - +0.70ms
unsure 🔍
-2% - +4%
-0.46ms - +0.72ms
tip-of-tree
tip-of-tree
18.23ms - 19.09msunsure 🔍
-4% - +3%
-0.70ms - +0.52ms
-unsure 🔍
-3% - +3%
-0.55ms - +0.64ms
previous-release
previous-release
18.21ms - 19.02msunsure 🔍
-4% - +2%
-0.72ms - +0.46ms
unsure 🔍
-3% - +3%
-0.64ms - +0.55ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
38.31ms - 41.51ms-unsure 🔍
-4% - +7%
-1.72ms - +2.83ms
unsure 🔍
-8% - +3%
-3.41ms - +1.39ms
tip-of-tree
tip-of-tree
37.73ms - 40.98msunsure 🔍
-7% - +4%
-2.83ms - +1.72ms
-unsure 🔍
-10% - +2%
-3.99ms - +0.85ms
previous-release
previous-release
39.13ms - 42.71msunsure 🔍
-4% - +9%
-1.39ms - +3.41ms
unsure 🔍
-2% - +10%
-0.85ms - +3.99ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.75ms - 11.45ms-unsure 🔍
-3% - +6%
-0.32ms - +0.67ms
unsure 🔍
-4% - +5%
-0.48ms - +0.53ms
tip-of-tree
tip-of-tree
10.57ms - 11.27msunsure 🔍
-6% - +3%
-0.67ms - +0.32ms
-unsure 🔍
-6% - +3%
-0.66ms - +0.36ms
previous-release
previous-release
10.71ms - 11.43msunsure 🔍
-5% - +4%
-0.53ms - +0.48ms
unsure 🔍
-3% - +6%
-0.36ms - +0.66ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
33.36ms - 34.97ms-unsure 🔍
-2% - +4%
-0.52ms - +1.38ms
unsure 🔍
-4% - +2%
-1.42ms - +0.62ms
tip-of-tree
tip-of-tree
33.23ms - 34.24msunsure 🔍
-4% - +1%
-1.38ms - +0.52ms
-faster ✔
0% - 5%
0.02ms - 1.64ms
previous-release
previous-release
33.93ms - 35.20msunsure 🔍
-2% - +4%
-0.62ms - +1.42ms
slower ❌
0% - 5%
0.02ms - 1.64ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
69.25ms - 70.94ms-unsure 🔍
-1% - +2%
-0.50ms - +1.60ms
unsure 🔍
-3% - +1%
-2.25ms - +0.70ms
tip-of-tree
tip-of-tree
68.93ms - 70.17msunsure 🔍
-2% - +1%
-1.60ms - +0.50ms
-unsure 🔍
-4% - +0%
-2.68ms - +0.03ms
previous-release
previous-release
69.67ms - 72.08msunsure 🔍
-1% - +3%
-0.70ms - +2.25ms
unsure 🔍
-0% - +4%
-0.03ms - +2.68ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
30.82ms - 31.55ms-unsure 🔍
-2% - +1%
-0.67ms - +0.40ms
unsure 🔍
-3% - +0%
-1.09ms - +0.07ms
tip-of-tree
tip-of-tree
30.93ms - 31.71msunsure 🔍
-1% - +2%
-0.40ms - +0.67ms
-unsure 🔍
-3% - +1%
-0.98ms - +0.22ms
previous-release
previous-release
31.25ms - 32.15msunsure 🔍
-0% - +4%
-0.07ms - +1.09ms
unsure 🔍
-1% - +3%
-0.22ms - +0.98ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
493.62ms - 501.97ms-unsure 🔍
-1% - +2%
-3.93ms - +7.46ms
unsure 🔍
-1% - +2%
-3.17ms - +7.71ms
tip-of-tree
tip-of-tree
492.16ms - 499.91msunsure 🔍
-1% - +1%
-7.46ms - +3.93ms
-unsure 🔍
-1% - +1%
-4.70ms - +5.72ms
previous-release
previous-release
492.04ms - 499.01msunsure 🔍
-2% - +1%
-7.71ms - +3.17ms
unsure 🔍
-1% - +1%
-5.72ms - +4.70ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
501.75ms - 508.84ms-unsure 🔍
-0% - +2%
-2.38ms - +7.82ms
unsure 🔍
-1% - +1%
-3.63ms - +6.92ms
tip-of-tree
tip-of-tree
498.91ms - 506.24msunsure 🔍
-2% - +0%
-7.82ms - +2.38ms
-unsure 🔍
-1% - +1%
-6.43ms - +4.28ms
previous-release
previous-release
499.75ms - 507.55msunsure 🔍
-1% - +1%
-6.92ms - +3.63ms
unsure 🔍
-1% - +1%
-4.28ms - +6.43ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Contributor

github-actions bot commented Mar 7, 2024

The size of lit-html.js and lit-core.min.js are as expected.

Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean fix! :D

@augustjk augustjk merged commit 4660f91 into main Mar 8, 2024
9 checks passed
@augustjk augustjk deleted the update-chromedriver-cdn branch March 8, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants