Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lit-starter-ts] fix missing mocha types #4595

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

majidsajadi
Copy link

Fixes #4594

Copy link

changeset-bot bot commented Mar 24, 2024

🦋 Changeset detected

Latest commit: ef2a2c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit/lit-starter-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

google-cla bot commented Mar 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

github-actions bot commented Mar 24, 2024

📊 Tachometer Benchmark Results

Summary

A summary of the benchmark results will show here once they finish.

Results

The full results of your benchmarks will show here once they finish.

tachometer-reporter-action v2 for Benchmarks

@majidsajadi majidsajadi force-pushed the lit-starter-ts/fix-missing-mocha-types branch from 118142e to acc7815 Compare March 24, 2024 10:46
@justinfagnani justinfagnani self-requested a review March 24, 2024 15:20
@justinfagnani
Copy link
Collaborator

Thanks @majidsajadi

This is missing an update to the package-lock.json file. Run npm i to sync. We'll also need a changeset file, which you can generate with npm run changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lit-starter-ts] missing type definition for mocha
2 participants