Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lit-starter-ts] fix missing prismjs theme #4597

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

majidsajadi
Copy link

Fixes #4596

Copy link

changeset-bot bot commented Mar 24, 2024

🦋 Changeset detected

Latest commit: c61474f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lit/lit-starter-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 24, 2024

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +7% (-0.19ms - +0.80ms)
    this-change vs tip-of-tree

render

  • this-change: 45.96ms - 47.90ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -5% - +3% (-0.85ms - +0.55ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.50ms - +0.74ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +3% (-0.28ms - +0.87ms)
    this-change vs tip-of-tree

update

  • this-change: 497.97ms - 504.65ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +10% (-1.10ms - +3.88ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-1.62ms - +1.02ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-8.91ms - +4.22ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 508.76ms - 515.18ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +1% (-9.56ms - +4.98ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
45.96ms - 47.90ms-

update

VersionAvg timevs
497.97ms - 504.65ms-

update-reflect

VersionAvg timevs
508.76ms - 515.18ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
17.76ms - 18.75ms-unsure 🔍
-5% - +3%
-0.85ms - +0.55ms
unsure 🔍
-6% - +2%
-1.09ms - +0.31ms
tip-of-tree
tip-of-tree
17.91ms - 18.89msunsure 🔍
-3% - +5%
-0.55ms - +0.85ms
-unsure 🔍
-5% - +2%
-0.94ms - +0.46ms
previous-release
previous-release
18.14ms - 19.14msunsure 🔍
-2% - +6%
-0.31ms - +1.09ms
unsure 🔍
-3% - +5%
-0.46ms - +0.94ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
38.67ms - 42.42ms-unsure 🔍
-3% - +10%
-1.10ms - +3.88ms
unsure 🔍
-8% - +5%
-3.22ms - +1.94ms
tip-of-tree
tip-of-tree
37.51ms - 40.79msunsure 🔍
-9% - +3%
-3.88ms - +1.10ms
-unsure 🔍
-11% - +1%
-4.44ms - +0.38ms
previous-release
previous-release
39.41ms - 42.95msunsure 🔍
-5% - +8%
-1.94ms - +3.22ms
unsure 🔍
-1% - +11%
-0.38ms - +4.44ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.85ms - 11.59ms-unsure 🔍
-2% - +7%
-0.19ms - +0.80ms
unsure 🔍
-4% - +5%
-0.48ms - +0.60ms
tip-of-tree
tip-of-tree
10.58ms - 11.24msunsure 🔍
-7% - +2%
-0.80ms - +0.19ms
-unsure 🔍
-7% - +2%
-0.76ms - +0.26ms
previous-release
previous-release
10.76ms - 11.55msunsure 🔍
-5% - +4%
-0.60ms - +0.48ms
unsure 🔍
-2% - +7%
-0.26ms - +0.76ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
32.95ms - 33.85ms-unsure 🔍
-2% - +2%
-0.50ms - +0.74ms
unsure 🔍
-2% - +2%
-0.63ms - +0.66ms
tip-of-tree
tip-of-tree
32.85ms - 33.72msunsure 🔍
-2% - +2%
-0.74ms - +0.50ms
-unsure 🔍
-2% - +2%
-0.73ms - +0.53ms
previous-release
previous-release
32.93ms - 33.85msunsure 🔍
-2% - +2%
-0.66ms - +0.63ms
unsure 🔍
-2% - +2%
-0.53ms - +0.73ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
69.08ms - 70.81ms-unsure 🔍
-2% - +1%
-1.62ms - +1.02ms
unsure 🔍
-4% - +0%
-2.83ms - +0.11ms
tip-of-tree
tip-of-tree
69.25ms - 71.24msunsure 🔍
-1% - +2%
-1.02ms - +1.62ms
-unsure 🔍
-4% - +1%
-2.61ms - +0.49ms
previous-release
previous-release
70.11ms - 72.49msunsure 🔍
-0% - +4%
-0.11ms - +2.83ms
unsure 🔍
-1% - +4%
-0.49ms - +2.61ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
31.13ms - 31.95ms-unsure 🔍
-1% - +3%
-0.28ms - +0.87ms
unsure 🔍
-0% - +3%
-0.13ms - +0.97ms
tip-of-tree
tip-of-tree
30.84ms - 31.65msunsure 🔍
-3% - +1%
-0.87ms - +0.28ms
-unsure 🔍
-1% - +2%
-0.42ms - +0.68ms
previous-release
previous-release
30.75ms - 31.49msunsure 🔍
-3% - +0%
-0.97ms - +0.13ms
unsure 🔍
-2% - +1%
-0.68ms - +0.42ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
510.26ms - 518.08ms-unsure 🔍
-2% - +1%
-8.91ms - +4.22ms
unsure 🔍
-2% - +1%
-7.77ms - +4.79ms
tip-of-tree
tip-of-tree
511.25ms - 521.79msunsure 🔍
-1% - +2%
-4.22ms - +8.91ms
-unsure 🔍
-1% - +2%
-6.35ms - +8.07ms
previous-release
previous-release
510.74ms - 520.58msunsure 🔍
-1% - +2%
-4.79ms - +7.77ms
unsure 🔍
-2% - +1%
-8.07ms - +6.35ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
551.48ms - 560.35ms-unsure 🔍
-2% - +1%
-9.56ms - +4.98ms
unsure 🔍
-1% - +1%
-4.84ms - +7.80ms
tip-of-tree
tip-of-tree
552.44ms - 563.97msunsure 🔍
-1% - +2%
-4.98ms - +9.56ms
-unsure 🔍
-1% - +2%
-3.55ms - +11.08ms
previous-release
previous-release
549.93ms - 558.95msunsure 🔍
-1% - +1%
-7.80ms - +4.84ms
unsure 🔍
-2% - +1%
-11.08ms - +3.55ms
-

tachometer-reporter-action v2 for Benchmarks

@justinfagnani
Copy link
Collaborator

We'll need a changeset file for this PR: https://github.com/lit/lit/blob/main/CONTRIBUTING.md#pull-requests

Copy link
Contributor

The size of lit-html.js and lit-core.min.js are as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lit-starter-ts] Missing prismjs theme
2 participants