Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention changesets in CONTRIBUTING.md #4599

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

justinfagnani
Copy link
Collaborator

We were missing this!

Copy link

changeset-bot bot commented Mar 25, 2024

🦋 Changeset detected

Latest commit: 3d10bfb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 25, 2024

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +6% (-0.39ms - +0.65ms)
    this-change vs tip-of-tree

render

  • this-change: 46.22ms - 48.82ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +3% (-0.68ms - +0.60ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +2% (-0.84ms - +0.80ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +0% (-0.98ms - +0.08ms)
    this-change vs tip-of-tree

update

  • this-change: 483.71ms - 491.29ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -6% - +7% (-2.18ms - +2.66ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +1% (-2.11ms - +0.61ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +0% (-2.71ms - +2.14ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 488.16ms - 496.20ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +0% (-4.37ms - +1.42ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
46.22ms - 48.82ms-

update

VersionAvg timevs
483.71ms - 491.29ms-

update-reflect

VersionAvg timevs
488.16ms - 496.20ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
18.31ms - 19.21ms-unsure 🔍
-4% - +3%
-0.68ms - +0.60ms
unsure 🔍
-1% - +5%
-0.26ms - +1.00ms
tip-of-tree
tip-of-tree
18.35ms - 19.25msunsure 🔍
-3% - +4%
-0.60ms - +0.68ms
-unsure 🔍
-1% - +6%
-0.22ms - +1.04ms
previous-release
previous-release
17.95ms - 18.83msunsure 🔍
-5% - +1%
-1.00ms - +0.26ms
unsure 🔍
-6% - +1%
-1.04ms - +0.22ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
38.16ms - 41.58ms-unsure 🔍
-6% - +7%
-2.18ms - +2.66ms
unsure 🔍
-3% - +9%
-1.30ms - +3.28ms
tip-of-tree
tip-of-tree
37.91ms - 41.35msunsure 🔍
-7% - +5%
-2.66ms - +2.18ms
-unsure 🔍
-4% - +8%
-1.55ms - +3.05ms
previous-release
previous-release
37.35ms - 40.41msunsure 🔍
-8% - +3%
-3.28ms - +1.30ms
unsure 🔍
-8% - +4%
-3.05ms - +1.55ms
-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
10.74ms - 11.46ms-unsure 🔍
-4% - +6%
-0.39ms - +0.65ms
unsure 🔍
-4% - +6%
-0.39ms - +0.63ms
tip-of-tree
tip-of-tree
10.60ms - 11.35msunsure 🔍
-6% - +4%
-0.65ms - +0.39ms
-unsure 🔍
-5% - +5%
-0.53ms - +0.51ms
previous-release
previous-release
10.62ms - 11.34msunsure 🔍
-6% - +3%
-0.63ms - +0.39ms
unsure 🔍
-5% - +5%
-0.51ms - +0.53ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
33.28ms - 34.30ms-unsure 🔍
-2% - +2%
-0.84ms - +0.80ms
unsure 🔍
-2% - +2%
-0.78ms - +0.75ms
tip-of-tree
tip-of-tree
33.17ms - 34.46msunsure 🔍
-2% - +2%
-0.80ms - +0.84ms
-unsure 🔍
-3% - +3%
-0.86ms - +0.86ms
previous-release
previous-release
33.24ms - 34.38msunsure 🔍
-2% - +2%
-0.75ms - +0.78ms
unsure 🔍
-3% - +3%
-0.86ms - +0.86ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
68.60ms - 70.01ms-unsure 🔍
-3% - +1%
-2.11ms - +0.61ms
unsure 🔍
-2% - +1%
-1.34ms - +0.67ms
tip-of-tree
tip-of-tree
68.89ms - 71.21msunsure 🔍
-1% - +3%
-0.61ms - +2.11ms
-unsure 🔍
-1% - +3%
-0.95ms - +1.78ms
previous-release
previous-release
68.92ms - 70.36msunsure 🔍
-1% - +2%
-0.67ms - +1.34ms
unsure 🔍
-3% - +1%
-1.78ms - +0.95ms
-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
29.99ms - 30.63ms-unsure 🔍
-3% - +0%
-0.98ms - +0.08ms
unsure 🔍
-2% - +1%
-0.60ms - +0.40ms
tip-of-tree
tip-of-tree
30.34ms - 31.18msunsure 🔍
-0% - +3%
-0.08ms - +0.98ms
-unsure 🔍
-1% - +3%
-0.22ms - +0.92ms
previous-release
previous-release
30.03ms - 30.79msunsure 🔍
-1% - +2%
-0.40ms - +0.60ms
unsure 🔍
-3% - +1%
-0.92ms - +0.22ms
-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
487.52ms - 490.88ms-unsure 🔍
-1% - +0%
-2.71ms - +2.14ms
unsure 🔍
-1% - +0%
-4.15ms - +1.36ms
tip-of-tree
tip-of-tree
487.75ms - 491.23msunsure 🔍
-0% - +1%
-2.14ms - +2.71ms
-unsure 🔍
-1% - +0%
-3.90ms - +1.68ms
previous-release
previous-release
488.42ms - 492.78msunsure 🔍
-0% - +1%
-1.36ms - +4.15ms
unsure 🔍
-0% - +1%
-1.68ms - +3.90ms
-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree
vs previous-release
previous-release
this-change
495.95ms - 500.03ms-unsure 🔍
-1% - +0%
-4.37ms - +1.42ms
unsure 🔍
-1% - +0%
-4.11ms - +0.86ms
tip-of-tree
tip-of-tree
497.41ms - 501.52msunsure 🔍
-0% - +1%
-1.42ms - +4.37ms
-unsure 🔍
-1% - +0%
-2.65ms - +2.35ms
previous-release
previous-release
498.19ms - 501.04msunsure 🔍
-0% - +1%
-0.86ms - +4.11ms
unsure 🔍
-0% - +1%
-2.35ms - +2.65ms
-

tachometer-reporter-action v2 for Benchmarks

Copy link
Contributor

The size of lit-html.js and lit-core.min.js are as expected.

Copy link
Contributor

@AndrewJakubowicz AndrewJakubowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@justinfagnani justinfagnani merged commit dd64885 into main Mar 25, 2024
9 checks passed
@justinfagnani justinfagnani deleted the contributing-changesets branch March 25, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants