test: upgrade chai to 5.x #4628
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9b9fd49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
justinfagnani
requested changes
Apr 23, 2024
|
have removed any empty let me know if that works (particularly the changeset, haven't done an empty one before) |
Upgrades chai to the latest version (5.x) which now ships as ESM directly, meaning we no longer need esm-bundle's fork.
|
i've rebased onto main and upgraded in the rollup plugin that got added to labs too FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades chai to the latest version (5.x) which now ships as ESM directly, meaning we no longer need esm-bundle's fork.
we may want to use node's built in test runner and assertion library for non-browser tests some day,
i also noticed we now have a mixture of
uvuandchai- maybe we want to settle on one some day 🤔