Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phy/generic_ddr: Change DDRLiteSPIClkGen's polarity to simplify LiteS… #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enjoy-digital
Copy link
Member

…PIDDRPHYCore's code.

@danc86
Copy link
Contributor

danc86 commented Oct 6, 2021

I tested this PR in my project, which is using Crosslink-NX with a Gigadevice GD25LQ128D flash chip. My design is working well with current Litespi master branch in DDR mode but it breaks with this patch applied.

Tomorrow I will try and collect some before and after traces so that we can compare what might be going wrong.

One thing to note is that my design requires extra_latency=1 to make DDR mode work. I wonder if this refactoring has changed the clock alignment such that this no longer lines up as it did before. I guess the Gigadevice is somehow more sensitive to clock signal alignment than other flash chips but I'm not sure how exactly. A trace will hopefully help to clarify.

@enjoy-digital
Copy link
Member Author

Thanks @danc86 for the feedback. I'll try to do more testing on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants