-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to MSW 2.0 #1380
base: main
Are you sure you want to change the base?
Upgrade to MSW 2.0 #1380
Conversation
@@ -40,7 +40,7 @@ | |||
"@liveblocks/jest-config": "*", | |||
"@types/ws": "^8.5.3", | |||
"dotenv": "^16.0.3", | |||
"msw": "^0.39.1", | |||
"msw": "^2.0.12", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSW doesn't seem to be used in @liveblocks/client
package but I updated it here anyway. I leave it to you to decide whether to remove it or not.
return res( | ||
ctx.json({ token: legacyTokens[requestCount++ % legacyTokens.length] }) | ||
); | ||
http.post("/mocked-api/legacy-auth", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are rather minimal but they bring your tests much closer to the platform. If you are curious, read about the 2.0 release.
Please let me know if there are any issues with the tests. The Vercel checks won't start since I'm not a team member (that's fine), and the GitHub Actions seems to be awaiting something. |
For Maintainers
Description
This updates the
msw
package across the entire Liveblocks monorepo to be of the latest version (2.0.12 at the moment).Thank you for using MSW! It means a lot to me. If you have a chance, please consider supporting the project on GitHub.
How to test it
Related issue(s)
Not related to any issues.