-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More prefactorings for module augmentation #1613
Conversation
Deployment failed with the following error:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
f69a79d
to
f597844
Compare
Deployment failed with the following error:
|
3769a9d
to
9e71794
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I'm still on the fence about the use*OrNull
naming convention and I think I would prefer something like useOptionalClient
but it's purely for stylistic reasons, maybe explicitness should stay the deciding factor.
I'm still hoping that none of those hooks should have to get exposed publicly, these |
Follow-up with more prefactorings after #1611. Again, this makes no functional changes.