Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More prefactorings for module augmentation #1613

Merged
merged 14 commits into from
May 15, 2024
Merged

Conversation

nvie
Copy link
Collaborator

@nvie nvie commented May 14, 2024

Follow-up with more prefactorings after #1611. Again, this makes no functional changes.

@nvie nvie self-assigned this May 14, 2024
Copy link

vercel bot commented May 14, 2024

Deployment failed with the following error:

Too many requests - try again in 4 minutes (more than 60, code: "api-deployments-flood").

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-nextjs-comments-audio ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 10:43am
examples-nextjs-comments-canvas ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 10:43am
examples-nextjs-comments-notifications ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 10:43am

@nvie nvie force-pushed the module-augmentation-prefactorings branch from f69a79d to f597844 Compare May 15, 2024 10:00
Copy link

vercel bot commented May 15, 2024

Deployment failed with the following error:

Too many requests - try again in 28 seconds (more than 60, code: "api-deployments-flood").

@nvie nvie force-pushed the module-augmentation-prefactorings branch from 3769a9d to 9e71794 Compare May 15, 2024 10:42
Copy link
Collaborator

@marcbouchenoire marcbouchenoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I'm still on the fence about the use*OrNull naming convention and I think I would prefer something like useOptionalClient but it's purely for stylistic reasons, maybe explicitness should stay the deciding factor.

@nvie
Copy link
Collaborator Author

nvie commented May 15, 2024

I'm still on the fence about the use*OrNull naming convention and I think I would prefer something like useOptionalClient but it's purely for stylistic reasons, maybe explicitness should stay the deciding factor.

I'm still hoping that none of those hooks should have to get exposed publicly, these OrNull versions are all private APIs.

@nvie nvie merged commit cbf08ee into main May 15, 2024
21 of 59 checks passed
@nvie nvie deleted the module-augmentation-prefactorings branch May 15, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants