Upgrade dependencies #974
Merged
Upgrade dependencies #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvie
commented
Jul 3, 2023
Comment on lines
+1
to
+9
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| import LiveblocksProvider from ".."; | ||
|
|
||
| describe("@liveblocks/yjs", () => { | ||
| test("TODO", () => { | ||
| // TODO: Add a real test here | ||
| expect(LiveblocksProvider).toEqual(LiveblocksProvider); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
@jrowny FYI, I added in this bogus test in the liveblocks-yui workspace, just so that running npm run test would not error with a non-zero exit code.
CTNicholas
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is this week's Monday morning dev dependency upgrade 馃槃
Turbo released a new version with my bug report addressed in it. Also, I contributed a lint rule to
publintthis weekend which already got merged.