Skip to content

Pin all direct dependencies #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Pin all direct dependencies #751

merged 2 commits into from
Jan 12, 2024

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Jan 12, 2024

No description provided.

Verified

This commit was signed with the committer’s verified signature.
rwaskiewicz Ryan Waskiewicz
@lukasIO lukasIO requested a review from Ocupe January 12, 2024 17:21
Copy link

changeset-bot bot commented Jan 12, 2024

🦋 Changeset detected

Latest commit: 8a5d8d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@livekit/components-core Patch
@livekit/components-react Patch
@livekit/component-example-next Patch
@livekit/components-js-docs Patch
@livekit/component-docs-storybook Patch
@livekit/components-docs-gen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO lukasIO requested a review from davidzhao January 12, 2024 17:21
Copy link
Contributor

github-actions bot commented Jan 12, 2024

size-limit report 📦

Path Size
LiveKitRoom only 1.84 KB (+0.49% 🔺)
LiveKitRoom with VideoConference 27.23 KB (+0.15% 🔺)
All exports 32.46 KB (+0.08% 🔺)

@lukasIO
Copy link
Contributor Author

lukasIO commented Jan 12, 2024

curious why this change has an impact on package size 👀

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@lukasIO lukasIO merged commit 3e15bde into main Jan 12, 2024
@lukasIO lukasIO deleted the pin-dependencies branch January 12, 2024 17:32
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants