Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat add prometheus auth #2252

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

holzgeist
Copy link

Hi there,

This PR adds support for basic auth on the prometheus server. We realized that it's open to the public when deploying via kubernetes and helm, as useHostnetwork is true to avoid UDP port range issues.

Any comments?

Thanks

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2023

CLA assistant check
All committers have signed the CLA.

@davidzhao
Copy link
Member

this is a good idea. the main feedback is it'd be great if we could consolidate prometheus options under a single object. I'm thinking something like:

prometheus:
  port: xxx
  username: xxx
  password: xxx

we'll make this backwards compatible and mark with a deprecation tag in the config. perhaps it's something we'll fully deprecate in 2.0

@holzgeist
Copy link
Author

Thanks for your feedback, I updated the PR accordingly.
I'm not sure how to make it backwards compatible and deprecate it though. Is this something you add on top?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants