Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autocert support #898

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

autocert support #898

wants to merge 2 commits into from

Conversation

dmisol
Copy link

@dmisol dmisol commented Aug 9, 2022

Autocert is supported (WSS, DTLS)
Matches comments on PR #867

@dmisol dmisol mentioned this pull request Aug 9, 2022
@davidzhao
Copy link
Member

Hi @dmisol, I tested it this and have made a couple of changes. The core change is working well! really impressive that it works automatically

A couple of issues that I still see:

  1. TURN/TLS does not work for me. You can test by using the SDK sample app, and selecting Force TURN. Could it be due to NextProtos being set to HTTP 1.1? TURN/TLS would need plain TCP
  2. After setting it up, when I visit https://domain with Chrome, it proceeds to give me a ERR_CERT_AUTHORITY_INVALID error. I think this is due to the autocert process.. I'm not sure if there's a way around it. Other browsers accepts the certificate without an issue.

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants