This repository has been archived by the owner on Aug 9, 2022. It is now read-only.
Implement error handling/display for transcoder loading #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #330 All the `notifyOnNetworkStatusChange: true` changes are necessary to get the "error" field of a graphQL query propagating all the way back to our component, unfortunately. See discussion here: livepeer/ui-kit#330 Also bumped all the Apollo versions. Didn't fix the problem but it also didn't introduce any so I kept the upgrade.
|
(To be clear, those screenshots are from a different branch — I didn't, like, introduce errors for the purpose of showing error handling 😃) |
This was referenced Feb 15, 2019
|
I'm going to revert this for now — it's caused inconsistency (#340) and "flickering" in a few areas of the UI, and there are higher-priority things to deploy. |
iameli
added a commit
that referenced
this pull request
Feb 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330
All the
notifyOnNetworkStatusChange: truechanges are necessary to getthe "error" field of a graphQL query propagating all the way back to our
component, unfortunately. See discussion here:
livepeer/ui-kit#330
Also bumped all the Apollo versions. Didn't fix the problem but it also
didn't introduce any so I kept the upgrade.
Screenshots (optional):
Checklist: