This repository has been archived by the owner on Mar 3, 2021. It is now read-only.
Support file paths with spaces for RETR command #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the FTP command is splitted by spaces, file paths with spaces are not supported, because the Retr command only uses the first part of the path until the first space. This change ensures all parts are used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the FTP command is splitted by spaces, file paths with spaces
are not supported, because the Retr command only uses the first part of
the path until the first space. This change ensures all parts are used.
This change fixed a specific problem for me, but I did not test other commands. However, looking at some FTP documentation, it seems that commands that accept more than one parameter are an exception, so I could imagine a command should just receive of string of all characters except the command name itself. That would solve the problem for all commands IMO.