[Tests] aria-role: add now-passing test

Fixes jsx-eslint#756.
ljharb · Oct 31, 2022 · 2b133ec · 2b133ec
1 parent 79b975a
commit 2b133ec
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/__tests__/src/rules/aria-role-test.js b/__tests__/src/rules/aria-role-test.js
@@ -76,9 +76,11 @@ ruleTester.run('aria-role', rule, {
     { code: '<img role="presentation" />', options: ignoreNonDOMSchema },
     {
       code: '<Div role="button" />',
-      errors: [errorMessage],
       settings: customDivSettings,
     },
+    {
+      code: '<svg role="graphics-document document" />',
+    },
   ].concat(validTests).map(parserOptionsMapper),
 
   invalid: [

diff --git a/package.json b/package.json
@@ -70,7 +70,7 @@
   "license": "MIT",
   "dependencies": {
     "@babel/runtime": "^7.19.4",
-    "aria-query": "^5.1.1",
+    "aria-query": "^5.1.3",
     "array-includes": "^3.1.5",
     "ast-types-flow": "^0.0.7",
     "axe-core": "^4.5.0",

diff --git a/src/rules/aria-role.js b/src/rules/aria-role.js
@@ -28,6 +28,8 @@ const schema = generateObjSchema({
   },
 });
 
+const validRoles = new Set([...roles.keys()].filter((role) => roles.get(role).abstract === false));
+
 export default {
   meta: {
     docs: {
@@ -41,7 +43,6 @@ export default {
     const options = context.options[0] || {};
     const ignoreNonDOM = !!options.ignoreNonDOM;
     const allowedInvalidRoles = new Set(options.allowedInvalidRoles || []);
-    const validRoles = new Set([...roles.keys()].filter((role) => roles.get(role).abstract === false));
     const elementType = getElementType(context);
 
     return ({