Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that non-functions passed to throws fail the test, just like assert #268

Merged
merged 1 commit into from Mar 6, 2016
Merged

Ensure that non-functions passed to throws fail the test, just like assert #268

merged 1 commit into from Mar 6, 2016

Conversation

ljharb
Copy link
Collaborator

@ljharb ljharb commented Mar 3, 2016

Fixes #267

@ljharb ljharb added the bug label Mar 3, 2016
@ljharb
Copy link
Collaborator Author

ljharb commented Mar 3, 2016

Two choices:

  • This will be a breaking change, and will necessitate a major version bump
  • this is a bug fix, since assert has always failed in these situations, and will be only a patch bump. (in this scenario, I will absolutely backport it to all of the major lines, and as many of the minors as i have patience for)

Thoughts?

@ghost
Copy link

ghost commented Mar 6, 2016

This seems like a patch update if it's fixing unexpected behavior. I hope there aren't tests in the wild that are depending on this bugfeature and they should probably fail anyhow.

@ljharb
Copy link
Collaborator Author

ljharb commented Mar 6, 2016

👍 thanks, i'll merge and release this as a series of patch updates soon then

ljharb added a commit that referenced this pull request Mar 6, 2016
@ljharb
Merge pull request #268 from ljharb/throws_non_function_should_fail
a51a89b 
[Fix] Ensure that non-functions passed to `throws` fail the test, just like `assert`
@ljharb ljharb merged commit a51a89b into tape-testing:master Mar 6, 2016
@gr2m gr2m mentioned this pull request Mar 7, 2016
Merged
@ljharb ljharb deleted the throws_non_function_should_fail branch March 8, 2016 06:26
jakelarkn pushed a commit to jakelarkn/tape that referenced this pull request Jul 11, 2017
@ljharb
Merge pull request tape-testing#268 from ljharb/throws_non_function_s…
4c0d9e6 
…hould_fail

[Fix] Ensure that non-functions passed to `throws` fail the test, just like `assert`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ljharb