Fix hardcoded ghcr.io path, add missing docker archs #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feedback are welcome, if it's looks so good. |
vincentbernat
requested changes
Jul 21, 2021
| linux/arm64 | ||
| linux/ppc64le | ||
| linux/s390x | ||
| push: ${{ github.event_name != 'pull_request' }} |
There was a problem hiding this comment.
There is a check above: github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags/'), so it can't match on pull request I think. If you modify it, be sure to not allow Docker push on push event, as I usually create my own branches in the same repository.
| - package-ecosystem: "github-actions" # See documentation for possible values | ||
| directory: "/" # Location of package manifests | ||
| schedule: | ||
| interval: "daily" |
There was a problem hiding this comment.
Is it for the generated Docker images? Otherwise, the project itself has no version requirements for its dependencies, so they should always be up-to-date.
| echo "Flags: ${{ steps.buildx.outputs.flags }}" | ||
| echo "Platforms: ${{ steps.buildx.outputs.platforms }}" | ||
| - name: Available platforms | ||
| run: echo ${{ steps.buildx.outputs.platforms }} |
There was a problem hiding this comment.
This is a duplicate, the information is available in the previous step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hardcoded ghcr.io path
ghcr.io/${{ github.repository }}
add missing docker archs
linux/386
linux/amd64
linux/arm64
linux/arm/v6
linux/arm/v7
linux/arm64
linux/ppc64le
linux/s390x
And fix the push at a PR