controller-runtime v0.16.2 updates

Fix breaking changes from upgrade of controller-runtime. Breaking changes from: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0 - kubernetes-sigs/controller-runtime#2407 - kubernetes-sigs/controller-runtime#2416 HIVE-2254 Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
lleshchi · Jan 27, 2024 · c433ab8 · c433ab8
1 parent 0aacdcf
commit c433ab8
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/cmd/manager/main.go b/cmd/manager/main.go
@@ -21,6 +21,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client/config"
 	"sigs.k8s.io/controller-runtime/pkg/manager"
 	"sigs.k8s.io/controller-runtime/pkg/manager/signals"
+	metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
 
 	_ "github.com/openshift/generic-admission-server/pkg/cmd"
 
@@ -155,9 +156,9 @@ func newRootCommand() *cobra.Command {
 			run := func(ctx context.Context) {
 				// Create a new Cmd to provide shared dependencies and start components
 				mgr, err := manager.New(cfg, manager.Options{
-					Scheme:             scheme.GetScheme(),
-					MetricsBindAddress: ":2112",
-					Logger:             utillogrus.NewLogr(log.StandardLogger()),
+					Scheme:  scheme.GetScheme(),
+					Metrics: metricsserver.Options{BindAddress: ":2112"},
+					Logger:  utillogrus.NewLogr(log.StandardLogger()),
 				})
 				if err != nil {
 					log.Fatal(err)

diff --git a/cmd/operator/main.go b/cmd/operator/main.go
@@ -18,6 +18,7 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/client/config"
 	"sigs.k8s.io/controller-runtime/pkg/manager"
 	"sigs.k8s.io/controller-runtime/pkg/manager/signals"
+	metricsserver "sigs.k8s.io/controller-runtime/pkg/metrics/server"
 
 	_ "github.com/openshift/generic-admission-server/pkg/cmd"
 
@@ -83,9 +84,9 @@ func newRootCommand() *cobra.Command {
 			run := func(ctx context.Context) {
 				// Create a new Cmd to provide shared dependencies and start components
 				mgr, err := manager.New(cfg, manager.Options{
-					Scheme:             scheme.GetScheme(),
-					MetricsBindAddress: ":2112",
-					Logger:             utillogrus.NewLogr(log.StandardLogger()),
+					Scheme:  scheme.GetScheme(),
+					Metrics: metricsserver.Options{BindAddress: ":2112"},
+					Logger:  utillogrus.NewLogr(log.StandardLogger()),
 				})
 				if err != nil {
 					log.Fatal(err)

diff --git a/test/e2e/common/machine.go b/test/e2e/common/machine.go
@@ -23,8 +23,8 @@ func WaitForMachines(cfg *rest.Config, testFunc func([]*machinev1.Machine) bool,
 	scheme := scheme.GetScheme()
 
 	internalCache, err := cache.New(cfg, cache.Options{
-		Namespaces: []string{"openshift-machine-api"},
-		Scheme:     scheme,
+		DefaultNamespaces: map[string]cache.Config{"openshift-machine-api": {}},
+		Scheme:            scheme,
 	})
 	if err != nil {
 		return err