[LLHD] Replace entity with module #6958
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!hw.inout
instead of!llhd.sig
to make things work withhw.module
(since inout types don't allow nested signals)llhd.entity
operation and use thehw.module
instead. This has two disadvantages: (1) all ports are now inout instead of separated in and out ports, however this was never verified in LLHD anyways and out ports were always more like inout, (2) instance and signal names cannot be verified to be unique within one module anymorehw.module
tollhd.entity
andhw.instance
tollhd.inst
. We can potentially implement the ModuleLike interface for ProcOp and get rid ofllhd.inst
as well.