[CIR][LowerToLLVM][CXXABI] Lower cir.va.arg #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
requested changes
Apr 29, 2024
clang/lib/CIR/Dialect/Transforms/LoweringPrepareArm64CXXABI.cpp
Outdated
Show resolved
Hide resolved
clang/lib/CIR/Dialect/Transforms/LoweringPrepareArm64CXXABI.cpp
Outdated
Show resolved
Hide resolved
ghehg
force-pushed
the
main
branch
3 times, most recently
from
168ca49
to
0a6e761
Compare
bcardosolopes
changed the title
bcardosolopes
requested changes
May 7, 2024
| @@ -1,4 +1,5 @@ | |||
| //====- LoweringPrepareItaniumCXXABI.h - Itanium ABI specific code --------===// | |||
| //====- LoweringPrepareItaniumCXXABI.cpp - Itanium ABI specific code | |||
| //--------===// | |||
There was a problem hiding this comment.
ops, this should fit in 80 instead
There was a problem hiding this comment.
Not resolved, please address this.
clang/lib/CIR/Dialect/Transforms/LoweringPrepareItaniumCXXABI.cpp
Outdated
Show resolved
Hide resolved
clang/lib/CIR/Dialect/Transforms/LoweringPrepareAArch64CXXABI.cpp
Outdated
Show resolved
Hide resolved
clang/lib/CIR/Dialect/Transforms/LoweringPrepareAArch64CXXABI.cpp
Outdated
Show resolved
Hide resolved
clang/lib/CIR/Dialect/Transforms/LoweringPrepareAArch64CXXABI.cpp
Outdated
Show resolved
Hide resolved
clang/lib/CIR/Dialect/Transforms/LoweringPrepareAArch64CXXABI.cpp
Outdated
Show resolved
Hide resolved
clang/lib/CIR/Dialect/Transforms/LoweringPrepareAArch64CXXABI.cpp
Outdated
Show resolved
Hide resolved
ghehg
force-pushed
the
main
branch
2 times, most recently
from
3adfff7
to
acede3e
Compare
bcardosolopes
requested changes
May 10, 2024
| @@ -1,4 +1,5 @@ | |||
| //====- LoweringPrepareItaniumCXXABI.h - Itanium ABI specific code --------===// | |||
| //====- LoweringPrepareItaniumCXXABI.cpp - Itanium ABI specific code | |||
| //--------===// | |||
There was a problem hiding this comment.
Not resolved, please address this.
clang/lib/CIR/Dialect/Transforms/LoweringPrepareItaniumCXXABI.cpp
Outdated
Show resolved
Hide resolved
clang/lib/CIR/Dialect/Transforms/LoweringPrepareItaniumCXXABI.cpp
Outdated
Show resolved
Hide resolved
clang/lib/CIR/Dialect/Transforms/LoweringPrepareAArch64CXXABI.cpp
Outdated
Show resolved
Hide resolved
clang/lib/CIR/Dialect/Transforms/LoweringPrepareAArch64CXXABI.cpp
Outdated
Show resolved
Hide resolved
clang/lib/CIR/Dialect/Transforms/LoweringPrepareItaniumCXXABI.h
Outdated
Show resolved
Hide resolved
clang/lib/CIR/Dialect/Transforms/LoweringPrepareItaniumCXXABI.cpp
Outdated
Show resolved
Hide resolved
bcardosolopes
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lowering var_arg op for ARM64 architecture. This is CIR lowering.
This PR modified LoweringPrepare CXXABI code to make LoweringPrepareArm64CXXABI class inherit more generic LoweringPrepareItaniumCXXABI, this way lowering var_arg would be only meaningful for arm64 targets and for other arch its no op for now.
The ABI doc and detailed algorithm description can be found in this official doc.
The following pic is a easier-to-understand and close to lowered code explanation