Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAG] Add SDPatternMatch m_ZExtOrSelf/m_SExtOrSelf/m_AExtOrSelf/m_TruncOrSelf matchers #85480

Merged
merged 1 commit into from Mar 20, 2024
Merged

[DAG] Add SDPatternMatch m_ZExtOrSelf/m_SExtOrSelf/m_AExtOrSelf/m_TruncOrSelf matchers #85480

merged 1 commit into from Mar 20, 2024
+65 −0

Conversation

marcauberer
Copy link
Member

Fixes #85395

@RKSimon RKSimon requested a review from mshockwave March 16, 2024 20:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 16, 2024 •
edited

✅ With the latest revision this PR passed the C/C++ code formatter.

@marcauberer
Copy link
Member Author

@RKSimon @mshockwave this is now ready for review.
I am not entirely sure how I would add negative tests, since an expression does always match with e.g. m_ZExtOrSelf(), because it is always "self". Maybe take a larger expression from InstCombine, that uses the InstCombine m_ZExtOrSelf() and modify it for the DAG unit test? What do you think?

RKSimon
RKSimon approved these changes Mar 20, 2024
View reviewed changes
Copy link
Collaborator

@RKSimon RKSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcauberer
Copy link
Member Author

@RKSimon can you merge? I do not have commit permissions.

@mshockwave mshockwave merged commit 17af9ad into llvm:main Mar 20, 2024
4 checks passed
chencha3 pushed a commit to chencha3/llvm-project that referenced this pull request Mar 23, 2024
@marcauberer @chencha3
[DAG] Add SDPatternMatch m_ZExtOrSelf/m_SExtOrSelf/m_AExtOrSelf/m_Tru…
4f99831 
…ncOrSelf matchers (llvm#85480)

Fixes llvm#85395
devnexen pushed a commit to devnexen/llvm-project that referenced this pull request Mar 23, 2024
@marcauberer @devnexen
[DAG] Add SDPatternMatch m_ZExtOrSelf/m_SExtOrSelf/m_AExtOrSelf/m_Tru…
ee0fc0e 
…ncOrSelf matchers (llvm#85480)

Fixes llvm#85395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RKSimon RKSimon RKSimon approved these changes

@mshockwave mshockwave Awaiting requested review from mshockwave

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SelectionDAG] Add m_ZExtOrSelf/m_SExtOrSelf/m_AExtOrSelf/m_TruncOrSelf pattern matchers
3 participants
@marcauberer @RKSimon @mshockwave