Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libc] Refactor BigInt #86137

Merged
merged 19 commits into from
Apr 4, 2024
Merged

[libc] Refactor BigInt #86137

merged 19 commits into from
Apr 4, 2024

Commits on Apr 4, 2024

  1. [libc] Refactor BigInt 

    This patch moves most of the multiprecision logic to the `multiword`
namespace and simplifies some logic in `BigInt`. It also fully
implements the mask and count functions. Additionnally many tests are
added.
    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    d01be9a View commit details
    Browse the repository at this point in the history

  2. Add fuzzing and fix signed right shift operator

    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    a3eba40 View commit details
    Browse the repository at this point in the history

  3. Add documention, fix imprecise comments, use a single macro instead o… 

    …t two.
    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5b7ccb2 View commit details
    Browse the repository at this point in the history

  4. Use mul_add instead of mad

    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5391d08 View commit details
    Browse the repository at this point in the history

  5. Fix comments

    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    72f7fa0 View commit details
    Browse the repository at this point in the history

  6. Remove unneeded local function

    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    967e3d7 View commit details
    Browse the repository at this point in the history

  7. Add a fast path for shifts when uint128 is available

    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    2e93ad2 View commit details
    Browse the repository at this point in the history

  8. Add parse_bigint tests

    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    f7f38bb View commit details
    Browse the repository at this point in the history

  9. Rename Double as DoubleWide

    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    f8b3563 View commit details
    Browse the repository at this point in the history

  10. Split division into functions and fix bug detected via fuzzing

    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    dbe42ea View commit details
    Browse the repository at this point in the history

  11. math_extras - remove generic implementation for add/sub overflow

    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    e4384cd View commit details
    Browse the repository at this point in the history

  12. Passing nullptr to __builtin_add_overflow generates ud2, switch… 

    …ing functions to "pass by ref"
    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    7249460 View commit details
    Browse the repository at this point in the history

  13. add static_assert for direction and remove additional if constexpr test

    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    cb7db94 View commit details
    Browse the repository at this point in the history

  14. Fix bogus test

    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    d4c1928 View commit details
    Browse the repository at this point in the history

  15. Make parse_bigint resilient to empty strings and nullptr

    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    4e15b8f View commit details
    Browse the repository at this point in the history

  16. Elide unnecessary statement

    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    ad60d1b View commit details
    Browse the repository at this point in the history

  17. Sprinkle LIBC_UNLIKELY on exceptionnal cases

    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    f6cc2b4 View commit details
    Browse the repository at this point in the history

  18. Restore if (bit_offset == 0) in shift and associated test

    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    cdb9bbe View commit details
    Browse the repository at this point in the history

  19. Simplify logic in parse_with_prefix

    @gchatelet
    gchatelet committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    6aef60e View commit details
    Browse the repository at this point in the history