-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libc][errno] Remove previously added errno numbers #92163
Conversation
@llvm/pr-subscribers-libc Author: Robin Caloudis (robincaloudis) ChangesIntroduced in #91150. Not needed anymore as #92041 fixed the root cause. Post mortem: Due to the previously missing inclusion of Full diff: https://github.com/llvm/llvm-project/pull/92163.diff 1 Files Affected:
diff --git a/libc/include/llvm-libc-macros/generic-error-number-macros.h b/libc/include/llvm-libc-macros/generic-error-number-macros.h
index b5b1b676dacc3..7ee0352669b8a 100644
--- a/libc/include/llvm-libc-macros/generic-error-number-macros.h
+++ b/libc/include/llvm-libc-macros/generic-error-number-macros.h
@@ -44,7 +44,5 @@
#define EDOM 33
#define ERANGE 34
#define EILSEQ 35
-#define ENAMETOOLONG 36
-#define EOVERFLOW 75
#endif // LLVM_LIBC_MACROS_GENERIC_ERROR_NUMBER_MACROS_H
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and thanks for explaining why this was an issue
You are welcome. Do you mind merging this PR? I still lack write access. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Do you mind resolving the merge conflict?
37e4df4
to
81fb3c0
Compare
Introduced in llvm#91150. Not needed anymore as llvm#92041 fixed the root cause. `ENAMETOOLONG` and `EOVERFLOW` are well defined in `<linux/errno.h>`. Post mortem: Due to the previously missing inclusion of `<linux/errno.h>` (fixed with llvm#92041), I misinterpreted an undefined macro issue during the development of llvm#91150 as being caused by a missing definition rather than by the missing inclusion of the linux header. I realized too late that `ENAMETOOLONG` and `EOVERFLOW` were correctly defined in `<linux/errno.h>` and that it was my missing inclusion that caused the problem.
Introduced in #91150. Not needed anymore as #92041 fixed the root cause.
ENAMETOOLONG
andEOVERFLOW
are well defined in<linux/errno.h>
.Post mortem: Due to the previously missing inclusion of
<linux/errno.h>
(fixed with #92041), I misinterpreted an undefined macro issue during the development of #91150 as being caused by a missing definition rather than by the missing inclusion of the linux header. I realized too late thatENAMETOOLONG
andEOVERFLOW
were correctly defined in<linux/errno.h>
and that it was my missing inclusion that caused the problem.