[libc][errno] Remove non asm generic error number

[robincaloudis]

The following small thing caught my eye:

1. EILSEQ is not part of the generic asm error number macros. See the full list of generic asm errno codes. AFAIK the generic asm errno numbers are common between different operating systems and architectures. EILSEQ is not part of this common set of errno's.

2. EILSEQ's value is wrong. During the addition of EILSEQ in https://reviews.llvm.org/D151129, the value 35 was probably chosen as its the consecutive number. This is not correct. The actual values can be looked up for example here:

   • For Linux kernel: EILSEQ = 84 (uapi; i.e. x86_64), EILSEQ = 88 (mips), EILSEQ = 47 (parisc)
   • For Darwin kernel: EILSEQ = 92

[llvmbot]

@llvm/pr-subscribers-libc

Author: Robin Caloudis (robincaloudis)

Changes

The following small thing caught my eye:

1. EILSEQ is not part of the generic asm error number macros. See the full list of generic asm errno codes. AFAIK the generic asm errno numbers are common between different operating systems and architectures. EILSEQ is not part of this common set of errno's.

2. EILSEQ's value is wrong. During the addition of EILSEQ in https://reviews.llvm.org/D151129, the value 35 was probably chosen as its the consecutive number. This is not correct. The actual values can be looked up for example here:

   • For Linux kernel: EILSEQ = 84 (uapi; i.e. x86_64), EILSEQ = 88 (mips), EILSEQ = 47 (parisc)
   • For Darwin kernel: EILSEQ = 92

---

Full diff: https://github.com/llvm/llvm-project/pull/92172.diff

1 Files Affected:

• (modified) libc/include/llvm-libc-macros/generic-error-number-macros.h (-1)

diff --git a/libc/include/llvm-libc-macros/generic-error-number-macros.h b/libc/include/llvm-libc-macros/generic-error-number-macros.h
index b5b1b676dacc3..cb4411fbac665 100644
--- a/libc/include/llvm-libc-macros/generic-error-number-macros.h
+++ b/libc/include/llvm-libc-macros/generic-error-number-macros.h
@@ -43,7 +43,6 @@
 #define EPIPE 32
 #define EDOM 33
 #define ERANGE 34
-#define EILSEQ 35
 #define ENAMETOOLONG 36
 #define EOVERFLOW 75
 

[michaelrj-google]

Thanks for catching this!

[robincaloudis]

You are welcome. Do you mind merging this PR? I still lack write access.

[jplehr]

Hi,
I think this broke the AMDGPU libc buildbot: https://lab.llvm.org/buildbot/#/builders/259/builds/4468
I'll see if I can fix it.

[robincaloudis]

Thanks for pointing out! Yes, it did. I realised it too. Didn't manage to fix it in the morning. I will look into it around 6pm (UTC+1). You are more than welcome to go ahead if you have an idea on how to fix the build. Thanks!