[flang][OpenMP] Add private to allocate in parallel-sections.f90

[kparzysz]

Add a privatizing clause to the construct that uses allocate clause. Amend the CHECK lines to reflect the expected output.

[llvmbot]

@llvm/pr-subscribers-flang-openmp

@llvm/pr-subscribers-flang-fir-hlfir

Author: Krzysztof Parzyszek (kparzysz)

Changes

Add a privatizing clause to the construct that uses allocate clause. Amend the CHECK lines to reflect the expected output.

---

Full diff: https://github.com/llvm/llvm-project/pull/92185.diff

1 Files Affected:

• (modified) flang/test/Lower/OpenMP/parallel-sections.f90 (+2-6)

diff --git a/flang/test/Lower/OpenMP/parallel-sections.f90 b/flang/test/Lower/OpenMP/parallel-sections.f90
index 2f78dd4562b0a..ff96bdc29d425 100644
--- a/flang/test/Lower/OpenMP/parallel-sections.f90
+++ b/flang/test/Lower/OpenMP/parallel-sections.f90
@@ -40,12 +40,8 @@ subroutine omp_parallel_sections_allocate(x, y)
   use omp_lib
   integer, intent(inout) :: x, y
   !CHECK: %[[allocator_1:.*]] = arith.constant 4 : i64
-  !CHECK: %[[allocator_2:.*]] = arith.constant 4 : i64
-  !CHECK: omp.parallel allocate(
-  !CHECK: %[[allocator_2]] : i64 -> %{{.*}} : !fir.ref<i32>) {
-  !CHECK: omp.sections allocate(
-  !CHECK: %[[allocator_1]] : i64 -> %{{.*}} : !fir.ref<i32>) {
-  !$omp parallel sections allocate(omp_high_bw_mem_alloc: x)
+  !CHECK: omp.sections allocate(%[[allocator_1]] : i64 -> %{{.*}} : !fir.ref<i32>) {
+  !$omp parallel sections allocate(omp_high_bw_mem_alloc: x) private(x, y)
     !CHECK: omp.section {
     !$omp section
       x = x + 12

[kiranchandramohan]

Did you miss the CHECK for parallel?

[kparzysz]

Added.

[tblah]

Thanks for the fix. nit: I think this test also does not need to depend upon openmp_runtime

[kparzysz]

Thanks for the fix. nit: I think this test also does not need to depend upon openmp_runtime

We'd need to remove the omp_high_bw_mem_alloc from the allocate clause. That symbol comes from omp_lib.mod, which is a part of the runtime. Are you ok with that, or should we leave it as it is now?

[kiranchandramohan]

LG.

[tblah]

Feel free to leave it as it is if it isn't trivial

[kparzysz]

The generated code will change slightly. This isn't the only test where the allocate modifier is used---we can decide later whether we want to keep using it in tests or not. Better yet, we'd fix the module dependency issue...