[Torch] Fix bugs for Torch::AtenOneHotOp
#3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelz913
requested review from
rsuderman,
vivekkhandelwal1 and
renxida
and removed request for
rsuderman
kuhar
reviewed
May 15, 2024
kuhar
reviewed
May 15, 2024
renxida
approved these changes
May 17, 2024
renxida
approved these changes
May 17, 2024
kuhar
reviewed
May 17, 2024
qedawkins
reviewed
May 17, 2024
|
@qedawkins can you take another look and merge if everything's addressed? |
|
Looks like the CI is failing for some reason. I can help merge after that's fixed. |
|
automerge enabled. Fix the CI and we're good to go! |
angelz913
force-pushed
the
one-hot-torch-to-linalg-fix
branch
7 times, most recently
from
d831391
to
7415983
Compare
This commit fixes bugs for the onnx.OneHot operator by: 1) Converting negative indices to non-negative indices 2) Handling both int and float types for off and on values 3) Using the correct result type It also includes a new unit test.
This commit fixes the bugs for Torch::AtenOneHotOp by: 1. Using Torch::kUnknownSize as the default value for numClasses in the pattern matching stage for DecomposeAtenOneHotOp 2. Adding AtenIntScalarOp to the patterns in TorchToArith 3. Handling both int and float types for off and on values in ONNX to Torch conversion It also includes: 1. A new test in TorchToArith/basic.mlir, for torch.aten.Int.Scalar, and 2. A new test in decompose-complex-ops.mlir, for torch.aten.one_hot
angelz913
force-pushed
the
one-hot-torch-to-linalg-fix
branch
from
7415983
to
4c58e11
Compare
BaneTrifa
pushed a commit
to BaneTrifa/torch-mlir
that referenced
this pull request
May 24, 2024
This PR fixes the bugs for `Torch::AtenOneHotOp` by: 1) Using `Torch::kUnknownSize` as the default value for `numClasses` in the pattern matching stage in `DecomposeAtenOneHotOp` 2) Adding `AtenIntScalarOp` to the patterns in `TorchToArith` 3) Handling both `int` and `float` types for `off` and `on` values in `TorchOnnxToTorch` conversion It also includes: 1) A new test in `TorchToArith/basic.mlir`, for `torch.aten.Int.Scalar`, and 2) A new test in `decompose-complex-ops.mlir`, for `torch.aten.one_hot` **Dependencies** This PR is dependent on llvm#3334.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bugs for
Torch::AtenOneHotOpby:Torch::kUnknownSizeas the default value fornumClassesinthe pattern matching stage in
DecomposeAtenOneHotOpAtenIntScalarOpto the patterns inTorchToArithintandfloattypes foroffandonvalues inTorchOnnxToTorchconversionIt also includes:
TorchToArith/basic.mlir, fortorch.aten.Int.Scalar, anddecompose-complex-ops.mlir, fortorch.aten.one_hotDependencies
This PR is dependent on #3334.