Merge pull request #280 from pasieronen/fix/memoize-getnamesbytype

Memoize names (increases speed by 10x)
lo1tuma · May 25, 2021 · 9446d16 · 9446d16
2 parents 6e0be1b + f9180cc
commit 9446d16
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 19 deletions.
diff --git a/benchmarks/runtime.bench.js b/benchmarks/runtime.bench.js
@@ -86,7 +86,7 @@ function lintManyFilesWithAllRecommendedRules({ numberOfFiles }) {
 describe('runtime', () => {
     it('should not take longer as the defined budget to lint many files with the recommended config', () => {
         const nodeVersionMultiplier = getNodeVersionMultiplier();
-        const budget = 70000000 / cpuSpeed * nodeVersionMultiplier;
+        const budget = 7000000 / cpuSpeed * nodeVersionMultiplier;
 
         const { medianDuration } = runBenchmark(() => {
             lintManyFilesWithAllRecommendedRules({ numberOfFiles: 350 });

diff --git a/lib/util/names.js b/lib/util/names.js
@@ -14,6 +14,7 @@ const map = require('ramda/src/map');
 const view = require('ramda/src/view');
 const assoc = require('ramda/src/assoc');
 const allPass = require('ramda/src/allPass');
+const memoizeWith = require('ramda/src/memoizeWith');
 
 const INTERFACES = {
     BDD: 'BDD',
@@ -115,12 +116,14 @@ function getNamesByType(type, filterOptions = {}) {
     return extractNames(filteredNames);
 }
 
+const getNamesByTypeMemoized = memoizeWith((type, options) => JSON.stringify({ type, options }), getNamesByType);
+
 function getTestCaseNames(options) {
-    return getNamesByType(TYPES.testCase, options);
+    return getNamesByTypeMemoized(TYPES.testCase, options);
 }
 
 function getSuiteNames(options) {
-    return getNamesByType(TYPES.suite, options);
+    return getNamesByTypeMemoized(TYPES.suite, options);
 }
 
 module.exports = {

diff --git a/test/util/namesSpec.js b/test/util/namesSpec.js
@@ -21,14 +21,6 @@ describe('mocha names', () => {
             expect(testCaseNames).to.deep.equal([]);
         });
 
-        it('always returns a new array', () => {
-            const testCaseNames1 = getTestCaseNames({ modifiersOnly: true });
-            const testCaseNames2 = getTestCaseNames({ modifiersOnly: true });
-
-            expect(testCaseNames1).to.deep.equal(testCaseNames2);
-            expect(testCaseNames1).to.not.equal(testCaseNames2);
-        });
-
         it('ignores invalid modifiers', () => {
             const testCaseNames = getTestCaseNames({ modifiers: [ 'foo' ], modifiersOnly: true });
 
@@ -185,14 +177,6 @@ describe('mocha names', () => {
             expect(suiteNames).to.deep.equal([]);
         });
 
-        it('always returns a new array', () => {
-            const suiteNames1 = getSuiteNames({ modifiersOnly: true });
-            const suiteNames2 = getSuiteNames({ modifiersOnly: true });
-
-            expect(suiteNames1).to.deep.equal(suiteNames2);
-            expect(suiteNames1).to.not.equal(suiteNames2);
-        });
-
         it('ignores invalid modifiers', () => {
             const suiteNames = getSuiteNames({ modifiers: [ 'foo' ], modifiersOnly: true });