Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint 7 #247

Merged
merged 3 commits into from May 13, 2020
Merged

ESLint 7 #247

merged 3 commits into from May 13, 2020

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented May 13, 2020

  • Breaking change: Require Node 10; add Node 14 to CI
  • npm: Update eslint devDep.

Haven't updated peerDeps at this point per discussion on #246, but let me know if you still want to go ahead with a bump.

@brettz9
Copy link
Contributor Author

brettz9 commented May 13, 2020

Sorry see there are some issues--not sure how I missed those. Will seek to resolve.

@brettz9 brettz9 mentioned this pull request May 13, 2020
@@ -190,7 +190,7 @@ ruleTester.run('no-setup-in-describe', rule, {
line: 1,
column: 28
}, {
messagee: memberExpressionError,
message: memberExpressionError,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to ESLint7! :) (It reports such unknown properties in the tester now)

Copy link
Owner

@lo1tuma lo1tuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lo1tuma lo1tuma merged commit 6012924 into lo1tuma:master May 13, 2020
@brettz9 brettz9 deleted the eslint7 branch May 13, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants