Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GH-910 separate error handlers #1000

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tomsaleeba
Copy link

This isn't a complete fix for #910 but it at least makes it so

  1. the original error isn't masked
  2. the promise is rejected so calling code can handle the error

I figured the ternary expression was only there because there was a single handler function.

Once I made this change, I could see that I was getting a transaction abort not an error. The distinction was hard to tell before just based on line numbers as they used the same function. The error for the aborted transaction is:
image

I don't know what's causing that, but that's not relevant to this PR. Although I'll happily accept any guesses on where to look for it.

CC @mimittqq who requested this in the linked issue too.

CC @tokmakoff

@tomsaleeba tomsaleeba marked this pull request as draft November 5, 2020 11:58
@tomsaleeba
Copy link
Author

Actually, swapping PR to draft. I should've looked closer at my screenshot. I'm not catching that error after all.

I'll figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant