Less .catch(reject)
-> less in mem promises in IndexedDb driver
#1034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small pattern change in
indexeddb.js
that should result a an unnoticeable performance improvement, by having one less promise instance in memory at a given moment in time for each method call on the driver.This also removes the unnecessary call to
.catch(reject)
.The old pattern:
The new pattern:
The
new Promise
is created afterinstance.ready()
has resolved, thus delayed, thus existing in mem for a shorter period of time.