New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export interfaces #983
base: master
Are you sure you want to change the base?
Export interfaces #983
Conversation
Export interfaces for convenient driver creation.
The tests seems to not pass. |
Actually I just noticed that interfaces are available without the need to explicitly import. Which is not nice, but at least it works. |
@thgreasi |
Closed by mistake. There is a real issue with current configuration. Because it allows to use modules even if not installed in (available for) particular package for example in the workspace project (when it is installed somewhere, and available everywhere). So anyway this should be changed. |
@whitecolor can you clarify what you mean with this a bit more? The installed part is what confused me. |
I think everything is ok. So one still have to import type localforage from 'localforage'
const options: LocalForageOptions |
Can you also try fixing the tests? |
Let me know if you would prefer me or someone else to pick this up. |
Yes, I don't know to fix the tests. As I said actually I'm ok with the current situation, exporting interface seems not actually necessary. But probably it would more correct to make them only available via explicit importing. |
Following my comment made four years ago =) #600 (comment)
Export interfaces for convenient driver creation.