New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] Add util script for building/pushing Docker images #10276
Draft
whummer
wants to merge
7
commits into
master
Choose a base branch
from
docker-helper
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
added
the
semver: patch
Non-breaking changes which can be included in patch releases
label
Feb 19, 2024
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 1h 26m 46s ⏱️ + 2m 15s Results for commit 0c4b4b3. ± Comparison against base commit 6880b98. This pull request removes 1 and adds 13 tests. Note that renamed tests count towards both.
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A common use case we're seeing is to build multi-arch Docker images with semantic versioning (build tags like
:3
,3.1
,latest
, etc), for which we currently have targets in the Makefile (docker-build
,docker-push-master
,docker-create-push-manifests
, etc). Maintaining this non-trivial logic in the Makefile is cumbersome, and we could also benefit from making it reusable across different repos. This PR is a first step towards making these targets reusable across different repos, including -ext, the upcoming Snowflake image, etc.Changes
Add util script for building/pushing Docker images. The script follows a similar structure as the existing
bin/release-helper.sh
script we already have in place.🚧 more details following soon.. /cc @alexrashed
TODOs:
__version__
in__init__.py
filesTesting
The script has been tested in an upstream pipeline (snowflake repo). Still need to coordinate whether and how to integrate the script into the build process of this repo.